From 24e71acf3f8be166083505b819c8c4d3c04694a9 Mon Sep 17 00:00:00 2001 From: Penar Musaraj Date: Thu, 9 Sep 2021 11:01:56 -0400 Subject: [PATCH] UX: Normalize sizing for inputs, buttons, dropdowns (#14226) See PR for details --- .../components/screened-ip-address-form.js | 2 +- .../templates/components/permalink-form.hbs | 57 +++++++------ .../components/screened-ip-address-form.hbs | 2 +- .../admin/addon/templates/email-index.hbs | 33 ++++---- .../addon/templates/email-preview-digest.hbs | 83 ++++++++++--------- .../admin/addon/templates/emojis.hbs | 13 ++- .../templates/logs/screened-ip-addresses.hbs | 6 +- .../templates/logs/staff-action-logs.hbs | 10 +-- .../app/templates/components/d-button.hbs | 3 + .../app/templates/components/date-picker.hbs | 3 +- .../components/edit-category-general.hbs | 8 +- .../templates/components/emoji-uploader.hbs | 8 +- .../components/future-date-input.hbs | 4 +- .../discourse/app/templates/composer.hbs | 2 +- .../discourse/app/templates/mobile/users.hbs | 42 +++++----- .../app/templates/user/bookmarks.hbs | 8 +- .../discourse/app/templates/users.hbs | 6 +- .../discourse/tests/acceptance/group-test.js | 2 +- .../tests/helpers/select-kit-helper.js | 5 +- .../integration/components/input-size-test.js | 60 ++++++++++++++ .../dropdown-select-box-header.hbs | 2 + .../stylesheets/common/admin/admin_base.scss | 36 +++----- .../common/admin/admin_emojis.scss | 28 ++----- .../common/admin/admin_report.scss | 5 -- .../stylesheets/common/admin/customize.scss | 17 +--- .../stylesheets/common/admin/dashboard.scss | 13 +-- .../stylesheets/common/admin/emails.scss | 12 --- .../stylesheets/common/admin/staff_logs.scss | 78 +++-------------- .../stylesheets/common/admin/suspend.scss | 6 -- .../stylesheets/common/base/_topic-list.scss | 18 +--- .../stylesheets/common/base/colorpicker.scss | 11 ++- .../stylesheets/common/base/compose.scss | 6 -- .../stylesheets/common/base/directory.scss | 17 +--- .../stylesheets/common/base/discourse.scss | 80 ++++++------------ .../common/base/edit-topic-timer-modal.scss | 30 ------- .../stylesheets/common/base/reviewables.scss | 12 --- .../stylesheets/common/base/share_link.scss | 40 +-------- .../common/components/bookmark-list.scss | 16 ---- .../common/components/buttons.scss | 21 ++--- .../common/components/date-input.scss | 2 +- .../common/components/date-picker.scss | 5 +- .../components/date-time-input-range.scss | 6 +- .../common/components/date-time-input.scss | 14 ++-- .../common/components/ignored-user-list.scss | 13 --- .../components/time-shortcut-picker.scss | 5 -- app/assets/stylesheets/common/d-editor.scss | 10 --- .../stylesheets/common/foundation/base.scss | 28 +++++++ .../stylesheets/common/foundation/mixins.scss | 17 ++++ .../common/foundation/variables.scss | 3 - .../common/select-kit/combo-box.scss | 5 +- .../select-kit/dropdown-select-box.scss | 8 +- .../future-date-input-selector.scss | 12 +++ .../common/select-kit/multi-select.scss | 7 +- .../common/select-kit/period-chooser.scss | 18 ++-- .../common/select-kit/select-kit.scss | 10 ++- app/assets/stylesheets/desktop/discourse.scss | 5 +- app/assets/stylesheets/mobile/_index.scss | 1 - .../stylesheets/mobile/admin_emojis.scss | 35 -------- app/assets/stylesheets/mobile/compose.scss | 10 +++ app/assets/stylesheets/mobile/discourse.scss | 21 +---- .../stylesheets/common/poll-ui-builder.scss | 23 ----- .../poll/assets/stylesheets/common/poll.scss | 6 -- .../discourse/lib/dummy-data.js.es6 | 1 + .../templates/styleguide/atoms/02-buttons.hbs | 12 +-- .../styleguide/atoms/05-input-fields.hbs | 63 +++++++++++++- .../styleguide/atoms/date-time-inputs.hbs | 20 ++++- .../templates/styleguide/atoms/dropdowns.hbs | 4 +- .../styleguide/organisms/navigation.hbs | 6 +- .../assets/stylesheets/styleguide.scss | 3 +- 69 files changed, 489 insertions(+), 689 deletions(-) create mode 100644 app/assets/javascripts/discourse/tests/integration/components/input-size-test.js delete mode 100644 app/assets/stylesheets/mobile/admin_emojis.scss diff --git a/app/assets/javascripts/admin/addon/components/screened-ip-address-form.js b/app/assets/javascripts/admin/addon/components/screened-ip-address-form.js index 5636c302dbe47..95ed9edfe81d2 100644 --- a/app/assets/javascripts/admin/addon/components/screened-ip-address-form.js +++ b/app/assets/javascripts/admin/addon/components/screened-ip-address-form.js @@ -17,7 +17,7 @@ import { schedule } from "@ember/runloop"; **/ export default Component.extend({ - classNames: ["screened-ip-address-form"], + classNames: ["screened-ip-address-form", "inline-form"], formSubmitted: false, actionName: "block", diff --git a/app/assets/javascripts/admin/addon/templates/components/permalink-form.hbs b/app/assets/javascripts/admin/addon/templates/components/permalink-form.hbs index 8792d78734c5c..938c77b0d8fdb 100644 --- a/app/assets/javascripts/admin/addon/templates/components/permalink-form.hbs +++ b/app/assets/javascripts/admin/addon/templates/components/permalink-form.hbs @@ -1,30 +1,35 @@ -{{i18n "admin.permalink.form.label"}} +
+ -{{text-field - value=url - disabled=formSubmitted - class="permalink-url" - placeholderKey="admin.permalink.url" - autocorrect="off" - autocapitalize="off"}} + {{text-field + value=url + disabled=formSubmitted + class="permalink-url" + placeholderKey="admin.permalink.url" + autocorrect="off" + autocapitalize="off" + }} -{{combo-box - content=permalinkTypes - value=permalinkType - onChange=(action (mut permalinkType)) - class="permalink-type" -}} + {{combo-box + content=permalinkTypes + value=permalinkType + onChange=(action (mut permalinkType)) + class="permalink-type" + }} -{{text-field - value=permalink_type_value - disabled=formSubmitted - class="external-url" - placeholderKey=permalinkTypePlaceholder - autocorrect="off" - autocapitalize="off"}} + {{text-field + value=permalink_type_value + disabled=formSubmitted + class="external-url" + placeholderKey=permalinkTypePlaceholder + autocorrect="off" + autocapitalize="off" + }} -{{d-button - class="btn-default" - action=(action "submit") - disabled=formSubmitted - label="admin.permalink.form.add"}} + {{d-button + class="btn-default" + action=(action "submit") + disabled=formSubmitted + label="admin.permalink.form.add" + }} +
diff --git a/app/assets/javascripts/admin/addon/templates/components/screened-ip-address-form.hbs b/app/assets/javascripts/admin/addon/templates/components/screened-ip-address-form.hbs index 488c14fb5ff87..a78a6c82e1708 100644 --- a/app/assets/javascripts/admin/addon/templates/components/screened-ip-address-form.hbs +++ b/app/assets/javascripts/admin/addon/templates/components/screened-ip-address-form.hbs @@ -1,4 +1,4 @@ -{{i18n "admin.logs.screened_ips.form.label"}} + {{text-field value=ip_address disabled=formSubmitted class="ip-address-input" placeholderKey="admin.logs.screened_ips.form.ip_address" autocorrect="off" autocapitalize="off"}} {{combo-box diff --git a/app/assets/javascripts/admin/addon/templates/email-index.hbs b/app/assets/javascripts/admin/addon/templates/email-index.hbs index ddf914fee4855..4919b249e6f7e 100644 --- a/app/assets/javascripts/admin/addon/templates/email-index.hbs +++ b/app/assets/javascripts/admin/addon/templates/email-index.hbs @@ -16,21 +16,24 @@
- {{#if sendingEmail}} -
{{i18n "admin.email.sending_test"}}
- {{else}} -
- {{text-field value=testEmailAddress placeholderKey="admin.email.test_email_address"}} +
+
+ {{#if sendingEmail}} + {{i18n "admin.email.sending_test"}} + {{else}} + {{text-field value=testEmailAddress placeholderKey="admin.email.test_email_address"}} + {{d-button + class="btn-primary" + action=(action "sendTestEmail") + disabled=sendTestEmailDisabled + label="admin.email.send_test" + type="submit" + }} + {{#if sentTestEmailMessage}} + {{sentTestEmailMessage}} + {{/if}} + {{/if}}
-
- {{d-button - class="btn-primary" - action=(action "sendTestEmail") - disabled=sendTestEmailDisabled - label="admin.email.send_test" - type="submit"}} - {{#if sentTestEmailMessage}}{{sentTestEmailMessage}}{{/if}} -
- {{/if}} +
diff --git a/app/assets/javascripts/admin/addon/templates/email-preview-digest.hbs b/app/assets/javascripts/admin/addon/templates/email-preview-digest.hbs index c93d048ba6dec..a4af09fb88106 100644 --- a/app/assets/javascripts/admin/addon/templates/email-preview-digest.hbs +++ b/app/assets/javascripts/admin/addon/templates/email-preview-digest.hbs @@ -2,32 +2,35 @@