[WIP] PreferredEmailDomain GitHub connector Config option

[tburko]

Considering implementing this. Will help identify users by verified company email without asking them to mark it as primary.

Sample config:

-connectors:
  - type: github
    id: github
    name: GitHub
    config:
      clientID: 'REDACTED'
      clientSecret: 'REDACTED'
      redirectURI: 'https://dex.acme.org/dex/callback'
      orgs:
        - name: acme
      preferredEmailDomain: 'acme.org'

[ericchiang]

I like it. Feel free to write up the implementation.

[ericchiang]

(We also might require that the user has that domain)

[ericchiang]

Actually this should probably just be a global thing. #66

So the config would have something like:

userFilters:
  requiredEmailDomains:
  - "@foo.com"
  - "@example.com"

[tburko]

Actually this should probably just be a global thing. #66

So the config would have something like:

userFilters:
  requiredEmailDomains:
  - "@foo.com"
  - "@example.com"

Hmm but that steps into authorization domain, I thought Dex was supposed to deal with identity. And a bigger change, if you want my help with this I would prefer to hear your thoughts on implementation first, we seem to have different approaches to structuring code :).

[ericchiang]

Hmm but that steps into authorization domain, I thought Dex was supposed to deal with identity. And a bigger change, if you want my help with this I would prefer to hear your thoughts on implementation first, we seem to have different approaches to structuring code :).

Sorry, I realized I'm getting these mixing up concepts. Yes, preferred email sounds good without my last suggestion :)

[povils]

Any updates?

[nabokihms]

Closed by #2740