Skip to content

Conversation

Myestery
Copy link
Contributor

@Myestery Myestery commented Aug 6, 2024

/claim #70

@Myestery Myestery requested a review from casendler as a code owner August 6, 2024 15:17
Copy link

height bot commented Aug 6, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@dray92
Copy link
Contributor

dray92 commented Aug 9, 2024

@Myestery can you check the lint errors?

@Myestery
Copy link
Contributor Author

Myestery commented Aug 9, 2024

@Myestery can you check the lint errors?

Okay

@Myestery
Copy link
Contributor Author

Myestery commented Aug 9, 2024

All good @dray92

@Myestery Myestery requested a review from dray92 August 12, 2024 14:54
@Sid-Lais
Copy link
Contributor

  1. We could use an uncropped screenshot as we do in our other docs for the architecture.
  2. Used a different format to link images and videos.

Used here is:

<figure><img src="../../.gitbook/assets/neondb.drawio.png" alt=""><figcaption></figcaption></figure>

We used:

![Azure VM Architecture](../../../.gitbook/assets/azure-vm-architecture.png)

@Myestery
Copy link
Contributor Author

  1. We could use an uncropped screenshot as we do in our other docs for the architecture.
  2. Used a different format to link images and videos.

Used here is:

<figure><img src="../../.gitbook/assets/neondb.drawio.png" alt=""><figcaption></figcaption></figure>

We used:

![Azure VM Architecture](../../../.gitbook/assets/azure-vm-architecture.png)

I was able to change no 2 but for no 1, I'll like to know which better tool I could use to achieve it cos I used draw io and it had to be cropped

@Sid-Lais
Copy link
Contributor

I was talking about the Create a new branch screenshot. For diagrams we use Lucid app

@Myestery
Copy link
Contributor Author

I was talking about the Create a new branch screenshot. For diagrams we use Lucid app

Fixed now with a better screenshot.

@Sid-Lais
Copy link
Contributor

In line 96 I guess launch command should be npm start which you mentioned earlier
The video just goes through the things and does not explain them clearly. Most importantly, the video voice is very low. You could try the app in the end by running some commands or something to show it works.
Should install postgres cli to check the postgres connectivity

@Sid-Lais
Copy link
Contributor

I was talking about the Create a new branch screenshot. For diagrams we use Lucid app

Fixed now with a better screenshot.

Delete the prev one

@dray92
Copy link
Contributor

dray92 commented Aug 19, 2024

@Myestery can you take a look?
rest of the PR seems good and we're ready to merge after this

@Myestery
Copy link
Contributor Author

Yeah I'll get it done in 24 hours

@Myestery
Copy link
Contributor Author

@Myestery can you take a look? rest of the PR seems good and we're ready to merge after this

Hello @dray92, I tried doing the tutorial again to replace the existing video but I can't load the DATABSE_URL env variable like I did before.
It looks like something has changed about the platform that I'm not aware of from the docs

@Myestery
Copy link
Contributor Author

Ready for merge

Hello @dray92 @Sid-Lais
I was contacted by someone from the team and I was able to redo the video using team secrets
It should be ready for merge now

@Sid-Lais
Copy link
Contributor

@Myestery can you check above as I have had put some comments that needs to be resolved

@Myestery
Copy link
Contributor Author

@Myestery can you check above as I have had put some comments that needs to be resolved

I have resolved those ones too

@Sid-Lais
Copy link
Contributor

@Myestery can you check above as I have had put some comments that needs to be resolved

I have resolved those ones too

I meant the minor grammatical errors

@Myestery
Copy link
Contributor Author

@Myestery can you check above as I have had put some comments that needs to be resolved

I have resolved those ones too

I meant the minor grammatical errors

I have wor

@Myestery can you check above as I have had put some comments that needs to be resolved

I have resolved those ones too

I meant the minor grammatical errors

I have worked on all the reviews you gave that I can find here. If there are any other ones, please point me to them

@Sid-Lais
Copy link
Contributor

in how-to-guides/third-party/neon-db.md

  1. line 19 It will be Current point in time not to time and make it bold
  2. line 124 in generating not ingenerating

@Myestery
Copy link
Contributor Author

done!

in how-to-guides/third-party/neon-db.md

  1. line 19 It will be Current point in time not to time and make it bold
  2. line 124 in generating not ingenerating

done!

@dray92 dray92 merged commit 50aa27e into devzero-inc:staging Aug 22, 2024
@Myestery Myestery deleted the neondb-branching branch July 14, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants