Skip to content

Commit 1d532cb

Browse files
committed
updated view url query param and error msgs
1 parent b0b98b2 commit 1d532cb

File tree

2 files changed

+18
-4
lines changed

2 files changed

+18
-4
lines changed

src/task_app/views.py

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
# Create your views here.
1515
class TaskView(APIView):
16-
permission_classes = [IsTaskOwner, IsAuthenticated]
16+
permission_classes = [IsAuthenticated]
1717
"""
1818
list all task or create a new task
1919
"""
@@ -27,8 +27,18 @@ def get(self, request, format=None):
2727
elif "tag" in request.GET:
2828
tag = request.GET["tag"]
2929
tagid = get_object_or_404(Tag, user=request.user, name=tag).id
30-
tags = get_list_or_404(Task, user=request.user, tag=tagid)
31-
serializer = TagSerializer(tags, many=True)
30+
tasks = get_list_or_404(Task, user=request.user, tag=tagid)
31+
serializer = TaskSerializer(tasks, many=True)
32+
return Response(serializer.data)
33+
elif "status" in request.GET:
34+
status = request.GET["status"]
35+
tasks = get_list_or_404(Task, user=request.user, status=status)
36+
serializer = TaskSerializer(tasks, many=True)
37+
return Response(serializer.data)
38+
elif "priority" in request.GET:
39+
priority = request.GET["priority"]
40+
tasks = get_list_or_404(Task, user=request.user, priority=int(priority))
41+
serializer = TaskSerializer(tasks, many=True)
3242
return Response(serializer.data)
3343

3444
tasks = Task.objects.filter(user=request.user).order_by('priority', 'deadline')

src/user_app/views.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,11 @@ def signUp(request):
4444
user.is_active = False
4545
user.save()
4646
else:
47-
return Response(serializer.errors, status=status.HTTP_500_INTERNAL_SERVER_ERROR)
47+
return Response({
48+
"status": "500",
49+
"message": "invalid data provided",
50+
"data":serializer.errors
51+
}, status=status.HTTP_500_INTERNAL_SERVER_ERROR)
4852

4953
data = {
5054
"status": "success",

0 commit comments

Comments
 (0)