fix: KUBECONFIG gets set when using --kubeconfig via var DEVSPACE_FLAGS

Signed-off-by: Armin Schlegel <armin.schlegel@gmx.de>

Author: siredmar

pkg/util/flags/flags.go

@@ -2,6 +2,7 @@ package flags
 
 import (
 	"fmt"
+	"os"
 	"strings"
 
 	"github.com/loft-sh/devspace/pkg/devspace/env"
@@ -18,6 +19,18 @@ func ApplyExtraFlags(cobraCmd *cobra.Command, osArgs []string, forceParsing bool
 		return nil, err
 	}
 
+	for i := 0; i < len(flags); i++ {
+		if flags[i] == "--kubeconfig" {
+			if i+1 < len(flags) {
+				err = os.Setenv("KUBECONFIG", flags[i+1])
+				if err != nil {
+					return nil, err
+				}
+				break
+			}
+		}
+	}
+
 	commandFlags, err := ParseCommandLine(env.GlobalGetEnv(envName))
 	if err != nil {
 		return nil, err

pkg/util/flags/flags_test.go

@@ -0,0 +1,37 @@
+package flags
+
+import (
+	"os"
+	"testing"
+
+	"github.com/loft-sh/devspace/cmd/flags"
+	"github.com/loft-sh/devspace/pkg/devspace/env"
+	"github.com/spf13/cobra"
+	"gotest.tools/assert"
+)
+
+func Test_ApplyExtraFlagsWithEmpty(t *testing.T) {
+	mycmd := cobra.Command{}
+	flags, err := ApplyExtraFlags(&mycmd, []string{}, false)
+	assert.NilError(t, err, "Error applying extra flags")
+	assert.Equal(t, 0, len(flags), "Flags should be empty")
+}
+
+func Test_ApplyExtraFlagsWithDevspaceFlags(t *testing.T) {
+	devspaceFlags := env.GlobalGetEnv("DEVSPACE_FLAGS")
+	assert.Equal(t, "", devspaceFlags, "DEVSPACE_FLAGS should be empty")
+
+	devspaceFlags = "-s --kubeconfig /path/to/kubeconfig --debug"
+	err := os.Setenv("DEVSPACE_FLAGS", devspaceFlags)
+	assert.NilError(t, err, "Error setting DEVSPACE_FLAGS")
+	mycmd := &cobra.Command{}
+	persistentFlags := mycmd.PersistentFlags()
+	_ = flags.SetGlobalFlags(persistentFlags)
+
+	flags, err := ApplyExtraFlags(mycmd, []string{}, false)
+	assert.NilError(t, err, "Error applying extra flags")
+	assert.Equal(t, 4, len(flags), "Flags should have 4 elements")
+
+	kubeconfig := env.GlobalGetEnv("KUBECONFIG")
+	assert.Equal(t, "/path/to/kubeconfig", kubeconfig, "Path should be /path/to/kubeconfig")
+}