Skip to content

docs: add custom objects beta API documentation #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 14, 2024

Conversation

shivansh
Copy link
Contributor

@shivansh shivansh commented Oct 1, 2024

https://app.devrev.ai/devrev/works/ISS-121317

The PR will be ready for review as soon as the custom object APIs are beta (in-progress) ✅

Copy link
Contributor

github-actions bot commented Oct 1, 2024

@shivansh shivansh force-pushed the shivansh/custom-objects-docs branch from a414340 to 338f6d2 Compare October 1, 2024 06:38
@shivansh shivansh force-pushed the shivansh/custom-objects-docs branch from 338f6d2 to 1e3a97d Compare October 1, 2024 06:40
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Copy link
Contributor

github-actions bot commented Oct 1, 2024

Copy link
Contributor

github-actions bot commented Oct 1, 2024

Copy link
Contributor

github-actions bot commented Oct 1, 2024

Copy link
Contributor

github-actions bot commented Oct 1, 2024

Copy link
Contributor

github-actions bot commented Oct 1, 2024

Copy link
Contributor

github-actions bot commented Oct 3, 2024

@shivansh shivansh force-pushed the shivansh/custom-objects-docs branch from 3d81199 to b26dec3 Compare October 3, 2024 04:06
Copy link
Contributor

github-actions bot commented Oct 3, 2024

@shivansh shivansh force-pushed the shivansh/custom-objects-docs branch from b26dec3 to dd654c9 Compare October 3, 2024 04:58
Copy link
Contributor

github-actions bot commented Oct 3, 2024

@shivansh shivansh changed the title docs: add custom objects API documentation docs: add custom objects beta API documentation Oct 3, 2024
@shivansh shivansh marked this pull request as ready for review October 3, 2024 05:11
@shivansh shivansh requested a review from a team as a code owner October 3, 2024 05:11
Comment on lines +71 to +72
"is_custom_leaf_type": true,
"id_prefix": "CAMP"
Copy link

@praneethratna praneethratna Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add definitions about is_custom_leaf_type and id_prefix?

"leaf_type": "campaign",
"filter": [
"eq",
"$custom_fields.ctype__target_audience",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"$custom_fields.ctype__target_audience",
"$custom_fields.tnt__target_audience",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

"name": "campaigns",
"field_type": "array",
"base_type": "id",
"id_type": "custom_object.campaign",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"id_type": "custom_object.campaign",
"id_type": ["custom_object.campaign"],

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

"id": "don:core:dvrv-us-1:devo/demo:custom_object/campaign/1",
"custom_fields": {
"tnt__budget": 15000
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
},
"custom_schema_spec": {
"tenant_fragment": true
}

Copy link
Contributor Author

@shivansh shivansh Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed IRL, let's omit this as things work fine.

Copy link
Contributor

github-actions bot commented Oct 3, 2024

@Atul-Butola Atul-Butola requested a review from bc-devrev October 3, 2024 11:01
@bc-devrev bc-devrev added the No EkLine Skip EkLine automated QA label Oct 3, 2024
Copy link
Contributor

github-actions bot commented Oct 3, 2024

🌟 EkLine Reviewer

Hello! I’m here to help improve your docs. I’ve reviewed your pull request, and left in-line suggestions for quick fixes. For details, visit the Analytics Page.

For questions or feedback, please email support@ekline.io.

1. **Leaf Type**: The base type of your custom object (e.g., "campaign"). Note that for custom objects, `is_custom_leaf_type` must be set to `true` to differentiate it from standard DevRev objects.
2. **Subtype**: A more specific categorization within a leaf type (e.g., "promotion" or "advertising" for a "campaign" leaf type).
3. **Custom Fields**: User-defined fields that store specific data for your custom object.
4. **Unique Key**: The `unique_key` is a unique identifier for each custom object. This is useful for maintaining idempotency when retrying custom object creation requests.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
4. **Unique Key**: The `unique_key` is a unique identifier for each custom object. This is useful for maintaining idempotency when retrying custom object creation requests.
4. **Unique key**: A unique identifier for each custom object. This is useful for maintaining idempotency when retrying custom object creation requests.

For more details on customization concepts, please refer to the
[Customization](./object-customization) documentation.

## Custom object lifecycle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the contents of this section up to the lifecycle operations reference.

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

@shivansh shivansh requested a review from bc-devrev October 11, 2024 06:42
Copy link
Contributor

@shivansh shivansh merged commit 82d6d4f into main Oct 14, 2024
3 checks passed
@shivansh shivansh deleted the shivansh/custom-objects-docs branch October 14, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No EkLine Skip EkLine automated QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants