-
Notifications
You must be signed in to change notification settings - Fork 3
chore: Include 'Bearer' in authorization header documentation #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🌟 EkLine ReviewerHello! I’m here to help improve your docs. I’ve reviewed your pull request, and left in-line suggestions for quick fixes. For details, visit the Analytics Page. For questions or feedback, please email support@ekline.io. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
EkLine
Consider using 'TBD' instead of 'Dev org'. (EK25033)
associated with your Dev org. After successful registration and verification of the endpoint, |
🚫 [EkLine]
'Event POST ******' should use sentence-style capitalization. (EK00037)
### Event POST `[json]` |
In general, don't use an ellipsis. (EK00011)
"work_created": {...} |
Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)
fern-api-docs/fern/docs/pages/welcome.mdx
Line 44 in 28968b8
Next, you'll want to set up your development environment to connect and interact with the DevRev API. |
@@ -139,19 +139,19 @@ | |||
Get the default rev org created along with the newly created account using the `rev-orgs.list` API: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using 'workspace' instead of 'rev org'. (EK25033)
Get the default rev org created along with the newly created account using the `rev-orgs.list` API: | |
Get the default workspace created along with the newly created account using the `rev-orgs.list` API: |
@@ -189,26 +189,26 @@ | |||
] | |||
} | |||
``` | |||
|
|||
Note the `display_id` (example: `REV-abcd`) of the rev org from the response. | |||
|
|||
- If there is an existing account then you can get the default rev org using the `rev-orgs.get` API: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using 'workspace' instead of 'rev org'. (EK25033)
- If there is an existing account then you can get the default rev org using the `rev-orgs.get` API: | |
- If there is an existing account then you can get the default workspace using the `rev-orgs.get` API: |
@@ -189,26 +189,26 @@ | |||
] | |||
} | |||
``` | |||
|
|||
|
|||
Note the `display_id` (example: `REV-abcd`) of the rev org from the response. | |||
|
|||
- If there is an existing account then you can get the default rev org using the `rev-orgs.get` API: | |||
|
|||
- Make a GET request to "https://api.devrev.ai/rev-orgs.get" using cURL with the `account` filter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using 'customer' instead of 'rev'. (EK25033)
- Make a GET request to "https://api.devrev.ai/rev-orgs.get" using cURL with the `account` filter. | |
- Make a GET request to "https://api.devrev.ai/rev-orgs.get" using cURL with the `customer` filter. |
-d account=ACC-12345 \ | ||
``` | ||
|
||
2. Make a POST request to "https://api.devrev.ai/rev-users.create" to create a rev-user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions:
- Consider using 'customer' instead of 'rev'. (EK25033)
- Consider using 'customer' instead of 'rev-user'. (EK25033)
2. Make a POST request to "https://api.devrev.ai/rev-users.create" to create a rev-user. | |
2. Make a POST request to "https://api.devrev.ai/rev-users.create" to create a customer. |
2. Go to the **Orgs** section and click on **+**. | ||
3. Fill in the details and click **Create**. | ||
|
||
Now you can find your newly created org in **Orgs**. | ||
|
||
Login into your demo org and [obtain the PAT token](/about/authentication#generate-a-personal-access-token-pat). | ||
Login into your demo org and [obtain the PAT token](/about/authentication#generate-a-personal-access-token-pat). | ||
Now you can use this PAT token to make test API calls and try building something new. | ||
|
||
In this tutorial, you will be able to retrive your account information by using the `dev-users` API. Let's get started with DevRev APIs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)
In this tutorial, you will be able to retrive your account information by using the `dev-users` API. Let's get started with DevRev APIs. | |
In this tutorial, you can retrieve your account information by using the `dev-users` API. Let's get started with DevRev APIs. |
@@ -30,11 +30,11 @@ | |||
|
|||
First, create a DevRev account or log in. | |||
|
|||
Every call to a DevRev API must include a PAT. After you create your account, [generate a personal access token](/about/authentication) and store it in a safe place. | |||
Every call to a DevRev API must include a PAT. After you create your account, [generate a personal access token](/about/authentication) and store it in a safe place. | |||
|
|||
In this guide, you’ll make a call to the [`dev-users.self`](/api-reference/dev-users/self) API which gets the authenticated user's information. You will retrieve the user object created for your account on DevRev. This user object contains information such as a unique identifier, full name, display name, and profile picture. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)
In this guide, you’ll make a call to the [`dev-users.self`](/api-reference/dev-users/self) API which gets the authenticated user's information. You will retrieve the user object created for your account on DevRev. This user object contains information such as a unique identifier, full name, display name, and profile picture. | |
In this guide, you make a call to the [`dev-users.self`](/api-reference/dev-users/self) API which gets the authenticated user's information. You retrieve the user object created for your account on DevRev. This user object contains information such as a unique identifier, full name, display name, and profile picture. |
@@ -123,7 +123,7 @@ | |||
</CodeBlock> | |||
|
|||
|
|||
The response contains `"id": "don:identity:dvrv-us-1:devo/20:devu/40",`. The `id` identifies the `devo` ID (Dev organization ID) as `devo/<devo-id>` and the `devu` ID (Dev user ID) as `devu/<devu-id>`. | |||
The response contains `"id": "don:identity:dvrv-us-1:devo/20:devu/40",`. The `id` identifies the `devo` ID (Dev organization ID) as `devo/<devo-id>` and the `devu` ID (Dev user ID) as `devu/<devu-id>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [EkLine]
Avoid using the term 'Dev user'. (EK25015)
The response contains `"id": "don:identity:dvrv-us-1:devo/20:devu/40",`. The `id` identifies the `devo` ID (Dev organization ID) as `devo/<devo-id>` and the `devu` ID (Dev user ID) as `devu/<devu-id>`. | |
The response contains `"id": "don:identity:dvrv-us-1:devo/20:devu/40",`. The `id` identifies the `devo` ID (Dev organization ID) as `devo/<devo-id>` and the `devu` ID (Developer user ID) as `devu/<devu-id>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)
In this tutorial, you'll learn how to create an account and contacts associated with it in DevRev via `accounts-create` and `rev-users.create` API. You can also [create accounts manually in DevRev app](https://docs.devrev.ai/product/customers#add-new-customers). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions:
- Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)
- Consider using 'workspace' instead of 'rev org'. (EK25033)
- Avoid using 'we' as it can come off as patronizing. For example, write 'The configuration is complete' rather than 'We are now done with the configuration.' (EK81039)
The `rev-users.create` API is used to create [contacts](https://docs.devrev.ai/product/grow#-contact) which represents an individual user associated with the account of the organization. To create a contact, we also need to use the `rev-orgs.list` API with the `accounts` filter to get the default [workspace](https://docs.devrev.ai/product/grow#-workspace)(rev org) created with the account. We will be creating a contact under the workspace (`rev_org`) of the account as contacts (`rev_user`) cannot exist individually without being associated with a workspace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)
You have now successfully created a contact for the account. You can check the contacts created on the DevRev app by going to **Customers** > **Contacts** or by clicking the account you created in **Accounts** and selecting the **Contacts** tab to view all the contacts created for the selected account. |
fern/docs/pages/custom-objects.mdx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, don't use an ellipsis. (EK00011)
"created_by": {...}, |
fern/docs/pages/custom-objects.mdx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, don't use an ellipsis. (EK00011)
"modified_by": {...}, |
fern/docs/pages/custom-objects.mdx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [EkLine]
Remove 'effectively' if it's not important to the meaning of the statement. (EK00006)
objects more effectively. The process is the same as adding subtypes to other standard |
fern/docs/pages/customization.mdx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)
process of tracking bugs in your organization. By the end of this section, you'll be able |
fern/docs/pages/customization.mdx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, don't use an ellipsis. (EK00011)
"created_by": {...}, |
fern/docs/pages/timeline-entries.mdx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)
In this tutorial, you'll learn how to send restricted visibility messages on the timeline of an object by using the `timeline-entries-create` API. These messages are only visible to the specific users you give access to. |
fern/docs/pages/timeline-entries.mdx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using 'agent' instead of 'bot'. (EK25033)
The [timeline entries](/api-reference/timeline-entries/create) API is used to create discussions (comments) on the timeline of an object such as a ticket or issue. These messages can be sent by users or by a bot. |
Published docs preview URL: https://devrev-preview-57585575-b8b3-4612-a9f6-3c57399cf497.docs.buildwithfern.com |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Published docs preview URL: https://devrev-preview-3da7eef9-0ab7-4ca2-881b-d68cc24e69bf.docs.buildwithfern.com |
@bc-devrev Let me know if I can dismiss these Ekline comments, I just added a bunch of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes Brian, you can disregard the EkLine comments.
ISS-180060