-
Notifications
You must be signed in to change notification settings - Fork 237
Specifically fetch the requested commit #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of fetching all tags and all heads, just fetch the requested commit. This accomplishes two things: 1. Avoids overzealous fetching of unrelated objects from the repo 2. Allows building commits which do not belong to any branch in a repository, such as merge commits generated by DrahtBot ([example](bitcoin/bitcoin@4cd306c)). Previously this was not possible.
devrandom
approved these changes
Dec 3, 2020
Interesting TIL that fetching by commit is possible. Though, it seems to only work with the full hash (not a truncated one) |
After this commit, building of Bitcoin 0.19.1 does not work anymore. Did I miss some documentation update? |
@MarkLTZ what are the actual symptoms? |
Using a cloned version of this repo with this commit rolled back everything work. |
These are commands used to compile:
|
devrandom
added a commit
that referenced
this pull request
Dec 7, 2020
This was referenced Dec 7, 2020
Merged
UdjinM6
pushed a commit
to UdjinM6/gitian-builder
that referenced
this pull request
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of fetching all tags and all heads, just fetch the requested commit. This accomplishes two things: