-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding more functionalities currently unimplemented in Java bindings #161
base: master
Are you sure you want to change the base?
Conversation
…audio track and audio track source
@singlerr Hi buddy, I am still new to JNI and I'm struggling to set it up locally so I can add more functionality as you've done. Well done! |
Hi! @kinsleykajiva , there is no way to set custom audio source instance in this pr. But, fortunately the author wrote some audio source implementations which can extract audio data from wav file. I planned it to my further commits. Also you can create jni yourself. |
ok noted , well I will have to keep on trying to set this up .
|
See WavAudioFileSource.cpp in meda/audio directory |
Ok, noted. I have looked at the code in that area, but I seem to see that it is for playback cases. Correct me if I am wrong. The goal, in the end, is to send audio chunks to that's the use case. But if this is going over my head, can you help me understand how to use this from the exposed Java APIs? |
@kinsleykajiva create wav audio source instance and attatch it to track by setAudioSource |
@devopvoid any update on adding this PR |
Created JNI bridges for functionalities that exists in native WebRTC but not webrtc java bindings
added RTCPeerConnection#setBitrate
added extra constructors for AudioProcessing that allows users to pass over audio settings(samplerates, stereo .etc)
added AudioTrackSource#addSink
...
for more informations please checkout the commits