Crash on calling MediaDevices.getAudioCaptureDevices();

[Toniboni08]

Describe the bug
If you call MediaDevices.getAudioCaptureDevices() on some minecraft events, the jvm crashes.

To Reproduce

1. clone the repo at https://github.com/Toniboni08/WebRTCCrashTest
2. run the gradle task "runClient"
3. join a world

Expected behavior
Upon the screen "loading tarrain..." the game crashes with a fatal jvm exception, where it later says: "The crash happened outside the Java Virtual Machine in native code."

Desktop (please complete the following information):

• OS: Windows 11
• Version: 24H2
• OS Build: 26100.4652

Additional context
It can be midigated in calling MediaDevices.getAudioCaptureDevices() in the constructor.

[devopvoid]

Thanks for the hint! The crash has now been fixed. But you still cannot query media devices in a Single-Threaded Apartment (STA).

Your event method is executed in the render thread which is single-threaded, obviously. In such cases an Error is thrown to notify that the query was not successful. You can handle that like in the snippet below.

The query in the constructor is executed in a worker thread, which is fine and will return the audio devices.

@SubscribeEvent
public static void onJoin(ClientPlayerNetworkEvent.LoggingIn event) {
    try {
        System.out.println("Audio Capture Devices: " + MediaDevices.getAudioCaptureDevices());
    }
    catch (Error e) {
        System.err.println("Error getting audio capture devices: " + e.getMessage());
    }
}

Soon I will release a new version with that bugfix included.

[devopvoid]

This also fixes #69.

[devopvoid]

Though, you can query the devices in a separate thread invoked from onJoin.

[Toniboni08]

Thank you!