Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Not Found ! #9

Open
Shayan-Ghani opened this issue Aug 12, 2024 · 8 comments
Open

Docker Not Found ! #9

Shayan-Ghani opened this issue Aug 12, 2024 · 8 comments
Labels
ansible ansible-related issues bug Something isn't working good first issue Good for newcomers

Comments

@Shayan-Ghani
Copy link
Member

Install and configure Docker on target (managed) node(s) (prepare_env role).

@Shayan-Ghani Shayan-Ghani added bug Something isn't working good first issue Good for newcomers ansible ansible-related issues labels Aug 12, 2024
@Shayan-Ghani Shayan-Ghani pinned this issue Aug 14, 2024
@RoninAngle1
Copy link

I have an Ansible playbook, if you mind, I will make it public tommaro , so you can take a look at it

@Shayan-Ghani
Copy link
Member Author

Great Idea!

@RoninAngle1
Copy link

Hi again
this is my repository https://github.com/RoninAngle1/ansible-docker-installation/tree/main, If you mind check it please

@RoninAngle1
Copy link

If it was useful please let me have a merge request

@Shayan-Ghani
Copy link
Member Author

Hey @RoninAngle1

Overall it looks awesome, and you'll be able to create the pr with the following improvements:

  • consider adding Docker-Compose version 2

  • Instead of prompting the user, get the values by lookup plugin from env vars to avoid interrupting the ci.

  • update the environment variable section of the wiki with the according to the changes made, under artifacts/wiki/index.html .

That would be great 💯👍🏽

@RoninAngle1
Copy link

@Shayan-Ghani I understood what to do, but these days I'm a bit busy at work, would you mind if I complete them by end of the week

@Shayan-Ghani
Copy link
Member Author

@RoninAngle1 No worries mate, take your time

@RoninAngle1
Copy link

RoninAngle1 commented Sep 24, 2024

Hi again dear friend @Shayan-Ghani
I created a poll request for this problem, sorry for being a bit late.
If you mind, check it please. I considered what was expected. the pull request number is #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ansible ansible-related issues bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants