new list methods (elmundio87#16)

* new list check methods

Author: eredi93

README.md

@@ -167,4 +167,12 @@ Will raise an AssertionError if the value of the property equals `unexpected_val
 ### TerraformPropertyList.should_match_regex(regex)
 
 Will raise an AssertionError if the value of the property does not match the value of `regex`
-  
+
+### TerraformPropertyList.list_should_contain([value])
+
+Will raise an AssertionError if the list value does not contain any of the `[value]`
+
+### TerraformPropertyList.list_should_not_contain([value])
+
+Will raise an AssertionError if the list value does contain any of the `[value]`
+

terraform_validate/fixtures/list_variable/1.tf

@@ -0,0 +1,7 @@
+resource "datadog_monitor" "foo" {
+  tags = ["baz:biz"]
+}
+
+resource "datadog_monitor" "bar" {
+  tags = ["baz:biz", "foo:bar"]
+}

terraform_validate/functional_test.py

@@ -315,6 +315,23 @@ def test_boolean_equal(self):
             for value in values:
                 validator.resources("aws_db_instance").property("storage_encrypted{0}".format(i)).should_equal(value)
 
+    def test_list_should_contain(self):
+        validator = t.Validator(os.path.join(self.path, "fixtures/list_variable"))
+        validator.resources("datadog_monitor").property("tags").list_should_contain(['baz:biz'])
+        expected_error = self.error_list_format([
+            "[datadog_monitor.bar.tags] '['baz:biz', 'foo:bar']' should contain '['too:biz']'.",
+            "[datadog_monitor.foo.tags] '['baz:biz']' should contain '['too:biz']'."
+        ])
+        with self.assertRaisesRegexp(AssertionError, expected_error):
+            validator.resources("datadog_monitor").property("tags").list_should_contain('too:biz')
+
+    def test_list_should_not_contain(self):
+        validator = t.Validator(os.path.join(self.path, "fixtures/list_variable"))
+        validator.resources("datadog_monitor").property("tags").list_should_not_contain(['foo:baz'])
+        validator.resources("datadog_monitor").property("tags").list_should_not_contain('foo:baz')
+        expected_error = self.error_list_format("[datadog_monitor.bar.tags] '['baz:biz', 'foo:bar']' should not contain '['foo:bar']'.")
+        with self.assertRaisesRegexp(AssertionError, expected_error):
+            validator.resources("datadog_monitor").property("tags").list_should_not_contain('foo:bar')
 
     def test_encryption_scenario(self):
         validator = t.Validator(os.path.join(self.path, "fixtures/enforce_encrypted"))

terraform_validate/terraform_validate.py

@@ -133,6 +133,57 @@ def should_not_equal(self,expected_value):
         if len(errors) > 0:
             raise AssertionError("\n".join(sorted(errors)))
 
+    def list_should_contain(self,values_list):
+        errors = []
+
+        if type(values_list) is not  list:
+            values_list = [values_list]
+
+        for property in self.properties:
+
+            actual_property_value = self.validator.substitute_variable_values_in_string(property.property_value)
+            values_missing = []
+            for value in values_list:
+                if value not in actual_property_value :
+                    values_missing.append(value)
+
+            if len(values_missing) != 0:
+                if type(actual_property_value) is list:
+                    actual_property_value = [str(x) for x in actual_property_value] # fix 2.6/7
+                errors.append("[{0}.{1}.{2}] '{3}' should contain '{4}'.".format(property.resource_type,
+                                                                        property.resource_name,
+                                                                        property.property_name,
+                                                                        actual_property_value,
+                                                                        values_missing))
+        if len(errors) > 0:
+            raise AssertionError("\n".join(sorted(errors)))
+
+    def list_should_not_contain(self,values_list):
+        errors = []
+
+        if type(values_list) is not  list:
+            values_list = [values_list]
+
+        for property in self.properties:
+
+            actual_property_value = self.validator.substitute_variable_values_in_string(property.property_value)
+            values_missing = []
+            for value in values_list:
+                if value in actual_property_value :
+                    values_missing.append(value)
+
+            if len(values_missing) != 0:
+                if type(actual_property_value) is list:
+                    actual_property_value = [str(x) for x in actual_property_value] # fix 2.6/7
+                errors.append("[{0}.{1}.{2}] '{3}' should not contain '{4}'.".format(property.resource_type,
+                                                                        property.resource_name,
+                                                                        property.property_name,
+                                                                        actual_property_value,
+                                                                        values_missing))
+        if len(errors) > 0:
+            raise AssertionError("\n".join(sorted(errors)))
+
+
     def should_have_properties(self, properties_list):
         errors = []