Add CircleCI. Fix formatting

Author: snemetz

.circleci/config.yml

@@ -0,0 +1,69 @@
+version: 2
+
+jobs:
+  build:
+    docker:
+      - image: hashicorp/terraform:0.11.3
+        entrypoint: /bin/sh
+    steps:
+      - checkout
+      - run:
+          name: "Validate tf files (terraform validate)"
+          command: |
+              find . -type f -name "*.tf" -exec dirname {} \;|sort -u | while read m; do (terraform validate -check-variables=false "$m" && echo "√ $m") || exit 1 ; done
+      - run:
+          name: "Check: Terraform formatting (terraform fmt)"
+          command: |
+              if [ `terraform fmt --list=true -diff=true -write=false | tee format-issues | wc -c` -ne 0 ]; then
+                echo "Some terraform files need be formatted, run 'terraform fmt' to fix"
+                echo "Formatting issues:"
+                cat format-issues
+                exit 1
+              fi
+      - run:
+          name: "Install: tflint"
+          command: |
+              apk add jq wget
+              # Get latest version of tflint
+              pkg_arch=linux_amd64
+              dl_url=$(curl -s https://api.github.com/repos/wata727/tflint/releases/latest | jq -r ".assets[] | select(.name | test(\"${pkg_arch}\")) | .browser_download_url")
+              wget ${dl_url}
+              unzip tflint_linux_amd64.zip
+              mkdir -p /usr/local/tflint/bin
+              # Setup PATH for later run steps - ONLY for Bash and not in Bash
+              #echo 'export PATH=/usr/local/tflint/bin:$PATH' >> $BASH_ENV
+              echo "Installing tflint..."
+              install tflint /usr/local/tflint/bin
+              echo "Configuring tflint..."
+              tf_ver=$(terraform version | awk 'FNR <= 1' | cut -dv -f2)
+              echo -e "\tConfig for terraform version: ${tf_ver}"
+              if [ -f '.tflint.hcl' ]; then
+                sed -i "/terraform_version =/s/\".*\"/\"${tf_ver}\"/" .tflint.hcl
+              else
+                {
+                echo -e "config {\nterraform_version = \"${tf_ver}\"\ndeep_check = true\nignore_module = {"
+                for module in $(grep -h '[^a-zA-Z]source[ =]' *.tf | sed -r 's/.*=\s+//' | sort -u); do
+                  # if not ^"../
+                  echo "${module} = true"
+                done
+                echo "}}"
+                } > .tflint.hcl
+                fi
+              echo "tflint configuration:"
+              cat .tflint.hcl
+      - run:
+          # Not supporting modules from registry ?? v0.5.4
+          # For now, must ignore in config file
+          name: "Check: tflint"
+          command: |
+              #echo "Initializing terraform..."
+              #terraform init -input=false
+              echo "Running tflint..."
+              /usr/local/tflint/bin/tflint --version
+              /usr/local/tflint/bin/tflint
+
+workflows:
+  version: 2
+  build:
+    jobs:
+      - build

README.md

@@ -1,3 +1,5 @@
+[![CircleCI](https://circleci.com/gh/devops-workflow/terraform-aws-efs.svg?style=svg)](https://circleci.com/gh/devops-workflow/terraform-aws-efs)
+
 # terraform-aws-efs
 
 Terraform module to provision an AWS [`EFS`](https://aws.amazon.com/efs/) Network File System.

main.tf

@@ -25,11 +25,11 @@ module "label" {
 }
 
 resource "aws_efs_file_system" "default" {
-  count             = "${module.enabled.value}"
-  performance_mode  = "${var.performance_mode}"
-  encrypted         = "${var.encrypted}"
-  kms_key_id        = "${var.kms_key_id}"
-  tags              = "${module.label.tags}"
+  count            = "${module.enabled.value}"
+  performance_mode = "${var.performance_mode}"
+  encrypted        = "${var.encrypted}"
+  kms_key_id       = "${var.kms_key_id}"
+  tags             = "${module.label.tags}"
 }
 
 resource "aws_efs_mount_target" "default" {
@@ -45,6 +45,7 @@ resource "aws_security_group" "default" {
   description = "EFS Access"
   vpc_id      = "${var.vpc_id}"
   tags        = "${module.label.tags}"
+
   lifecycle {
     create_before_destroy = true
   }

outputs.tf

@@ -3,10 +3,12 @@ output "dns_name" {
   description = ""
   value       = "${element(concat(aws_efs_file_system.default.*.dns_name, list("")),0)}"
 }
+
 output "id" {
   description = "ID of EFS"
   value       = "${element(concat(aws_efs_file_system.default.*.id, list("")),0)}"
 }
+
 output "kms_key_id" {
   description = ""
   value       = "${element(concat(aws_efs_file_system.default.*.kms_key_id, list("")),0)}"
@@ -24,10 +26,12 @@ output "mount_target_ids" {
   description = "List of IDs of the EFS mount targets"
   value       = ["${aws_efs_mount_target.default.*.id}"]
 }
+
 output "mount_target_ips" {
   description = "List of IPs of the EFS mount targets"
   value       = ["${aws_efs_mount_target.default.*.ip_address}"]
 }
+
 output "mount_target_net_intf_ids" {
   description = "List of network interface IDs of the EFS mount targets"
   value       = ["${aws_efs_mount_target.default.*.id}"]

test/main.tf

@@ -1,16 +1,20 @@
 module "efs" {
-  source          = "../"
-  name            = "efs-vol"
-  environment     = "testing"
-  organization    = ""
+  source       = "../"
+  name         = "efs-vol"
+  environment  = "testing"
+  organization = ""
+
   #attributes      = ["role", "policy", "use", ""]
   #tags            = "${map("Key", "Value")}"
-  zone_id         = "ZURF67XJUWC5A" # one
+  zone_id = "ZURF67XJUWC5A" # one
+
   security_groups = []
-  subnets         = ["subnet-857efce3","subnet-0852f140","subnet-6395c038"]
-  vpc_id          = "vpc-417c0027"  # one
+  subnets         = ["subnet-857efce3", "subnet-0852f140", "subnet-6395c038"]
+  vpc_id          = "vpc-417c0027"                                            # one
+
   #enabled         = false
 }
 
 # Test:
 #   enabled = false
+

variables.tf

@@ -1,36 +1,42 @@
-
 // Variables specific to module label
 variable "attributes" {
   description = "Suffix name with additional attributes (policy, role, etc.)"
   type        = "list"
   default     = []
 }
+
 variable "delimiter" {
   description = "Delimiter to be used between `name`, `namespaces`, `attributes`, etc."
   type        = "string"
   default     = "-"
 }
+
 variable "environment" {
   description = "Environment (ex: dev, qa, stage, prod)"
   type        = "string"
 }
+
 variable "name" {
   description = "Base name for resource"
   type        = "string"
 }
+
 variable "namespace-env" {
   description = "Prefix name with the environment"
   default     = true
 }
+
 variable "namespace-org" {
   description = "Prefix name with the organization. If both env and org namespaces are used, format will be <org>-<env>-<name>"
   default     = false
 }
+
 variable "organization" {
   description = "Organization name"
   type        = "string"
   default     = ""
 }
+
 variable "tags" {
   description = "A map of additional tags to add"
   type        = "map"
@@ -43,6 +49,7 @@ variable "dns_ttl" {
   type        = "string"
   default     = "60"
 }
+
 variable "zone_id" {
   description = "Route53 DNS zone ID"
   type        = "string"
@@ -54,34 +61,41 @@ variable "enabled" {
   description = "Set to false to prevent the module from creating anything"
   default     = true
 }
+
 variable "encrypted" {
   description = "If true, the disk will be encrypted"
   type        = "string"
   default     = "false"
 }
+
 variable "kms_key_id" {
   description = "ARN for the KMS encryption key. When specifying kms_key_id, encrypted needs to be set to true"
   type        = "string"
   default     = ""
 }
+
 variable "performance_mode" {
   description = "The file system performance mode. Can be either generalPurpose or maxIO"
   type        = "string"
   default     = "generalPurpose"
 }
+
 variable "region" {
   description = "AWS region"
   type        = "string"
   default     = ""
 }
+
 variable "security_groups" {
   description = "AWS security group IDs to allow to connect to the EFS"
   type        = "list"
 }
+
 variable "subnets" {
   description = "AWS subnet IDs"
   type        = "list"
 }
+
 variable "vpc_id" {
   description = "AWS VPC ID"
   type        = "string"