Skip to content

Commit 6e9c456

Browse files
committed
isMetaKey -> isModKey
1 parent 70626ff commit 6e9c456

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

app/components/Editor.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import UiStore from "stores/UiStore";
88
import ErrorBoundary from "components/ErrorBoundary";
99
import Tooltip from "components/Tooltip";
1010
import embeds from "../embeds";
11-
import { isMetaKey } from "utils/keyboard";
11+
import { isModKey } from "utils/keyboard";
1212
import { uploadFile } from "utils/uploadFile";
1313
import { isInternalUrl } from "utils/urls";
1414

@@ -50,7 +50,7 @@ function Editor(props: PropsWithRef) {
5050
return;
5151
}
5252

53-
if (isInternalUrl(href) && !isMetaKey(event) && !event.shiftKey) {
53+
if (isInternalUrl(href) && !isModKey(event) && !event.shiftKey) {
5454
// relative
5555
let navigateTo = href;
5656

app/scenes/Document/components/Editor.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import Editor from "components/Editor";
1313
import Flex from "components/Flex";
1414
import HoverPreview from "components/HoverPreview";
1515
import Star, { AnimatedStar } from "components/Star";
16-
import { isMetaKey } from "utils/keyboard";
16+
import { isModKey } from "utils/keyboard";
1717
import { documentHistoryUrl } from "utils/routeHelpers";
1818

1919
type Props = {
@@ -55,7 +55,7 @@ class DocumentEditor extends React.Component<Props> {
5555
handleTitleKeyDown = (event: SyntheticKeyboardEvent<>) => {
5656
if (event.key === "Enter") {
5757
event.preventDefault();
58-
if (isMetaKey(event)) {
58+
if (isModKey(event)) {
5959
this.props.onSave({ done: true });
6060
return;
6161
}
@@ -69,12 +69,12 @@ class DocumentEditor extends React.Component<Props> {
6969
this.focusAtStart();
7070
return;
7171
}
72-
if (event.key === "p" && isMetaKey(event) && event.shiftKey) {
72+
if (event.key === "p" && isModKey(event) && event.shiftKey) {
7373
event.preventDefault();
7474
this.props.onSave({ publish: true, done: true });
7575
return;
7676
}
77-
if (event.key === "s" && isMetaKey(event)) {
77+
if (event.key === "s" && isModKey(event)) {
7878
event.preventDefault();
7979
this.props.onSave({});
8080
return;

app/utils/keyboard.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ export const metaDisplay = isMac ? "⌘" : "Ctrl";
55

66
export const meta = isMac ? "cmd" : "ctrl";
77

8-
export function isMetaKey(
8+
export function isModKey(
99
event: KeyboardEvent | MouseEvent | SyntheticKeyboardEvent<>
1010
) {
1111
return isMac ? event.metaKey : event.ctrlKey;

0 commit comments

Comments
 (0)