Skip to content

skipping non limited products #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

skipping non limited products #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f2a097
skipping non limited products
dam-bal Apr 27, 2023
f8c2f1e
improvement
dam-bal Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions DDD.BuildingBlocks.V9.OutOfProcDependency/Core/Cart/CheckoutCart.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,17 @@ public void SetPayment(Payment payment)

public async Task<Order.Order> PlaceOrder(IOrderRepository orderRepository)
{
var limitedProducts = Products.Where(x => x.Product.LimitedAvailability);

/*
* This is obviously a naive implementation but in same cases might yield better results
* than using JOINs, since we can issue simpler queries in parallel and then
* scatter and collect with Task.WhenAll(...)
*/
foreach (var product in Products)
foreach (var limitedProduct in limitedProducts)
{
var orderWithLimitedProductExistsInThisQuarter = await orderRepository.Exists(
specification: new ActiveOrderWithLimitedProductThisQuarter(CustomerId, product.Product.Name),
specification: new ActiveOrderWithLimitedProductThisQuarter(CustomerId, limitedProduct.Product.Name),
cancellationToken: CancellationToken.None);

if (orderWithLimitedProductExistsInThisQuarter)
Expand Down