-
-
Notifications
You must be signed in to change notification settings - Fork 7
Set DotnetTool package type when PackAsTool=true #681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: kzu <169707+kzu@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix missing DotnetTool package type in nuspec metadata
Set DotnetTool package type when PackAsTool=true
Jan 14, 2026
Member
🧪 Details on Microsoft Windows 10.0.26100from dotnet-retest v1.0.0 on .NET 10.0.1 with 💜 by @devlooped |
This was referenced Jan 15, 2026
agocke
pushed a commit
to serdedotnet/serde
that referenced
this pull request
Jan 18, 2026
Updated [NuGetizer](https://github.com/devlooped/nugetizer) from 1.4.5 to 1.4.7. <details> <summary>Release notes</summary> _Sourced from [NuGetizer's releases](https://github.com/devlooped/nugetizer/releases)._ ## 1.4.7 <!-- Release notes generated using configuration in .github/release.yml at main --> ## What's Changed ### 🔨 Other * Set DotnetTool package type when PackAsTool=true by @Copilot in devlooped/nugetizer#681 **Full Changelog**: devlooped/nugetizer@v1.4.6...v1.4.7 <!-- sponsors --> <!-- avoid this section by leaving a nosponsors tag --> ## Sponsors The following sponsors made this release possible: @clarius, @MFB-Technologies-Inc, @sandrock, @drivenet, @Keflon, @tbolon, @kfrancis, @unoplatform, @rbnswartz, @jfoshee, @Mrxx99, @eajhnsn1, @davidjenni, @Jonathan-Hickey, @KenBonny, @SimonCropp, @agileworks-eu, @arsdragonfly, @vezel-dev, @ChilliCream, @4OTC, @v-limo, @DominicSchell, @adalon, @Eule02, @henkmartijn, @torutek, @mccaffers, @cleosia. Thanks 💜 <!-- /sponsors --> ## 1.4.6 <!-- Release notes generated using configuration in .github/release.yml at main --> ## What's Changed ### 🐛 Fixed bugs * Fix rendering in nugetize of multiple packages by @kzu in devlooped/nugetizer#672 ### 🔨 Other * Add support for SLNX format when running nugetize by @kzu in devlooped/nugetizer#671 **Full Changelog**: devlooped/nugetizer@v1.4.5...v1.4.6 <!-- sponsors --> <!-- avoid this section by leaving a nosponsors tag --> ## Sponsors The following sponsors made this release possible: @clarius, @MFB-Technologies-Inc, @drivenet, @Keflon, @tbolon, @kfrancis, @unoplatform, @rbnswartz, @jfoshee, @Mrxx99, @eajhnsn1, @davidjenni, @Jonathan-Hickey, @akunzai, @KenBonny, @SimonCropp, @agileworks-eu, @arsdragonfly, @vezel-dev, @ChilliCream, @4OTC, @v-limo, @DominicSchell, @jwendl, @adalon, @Eule02, @henkmartijn, @torutek, @mccaffers. Thanks 💜 <!-- /sponsors --> Commits viewable in [compare view](devlooped/nugetizer@v1.4.5...v1.4.7). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
PackAsTool=true, nugetizer was not emitting theDotnetToolpackage type in the nuspec metadata, unlike the built-in .NET SDK Pack.Changes
NuGetizer.PackageMetadata.targets: Added condition to setPackageTypes="DotnetTool"whenPackAsTool=trueand no explicitPackageTypeis specifiedgiven_a_tool_project.cs: Added test to verify the package type is set correctlyResult
Projects with
PackAsTool=truenow correctly emit:Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
pkg.kzu.app/usr/bin/dotnet dotnet build(dns block)/usr/bin/dotnet dotnet restore --ignore-failed-sources owner --uid-owner 0 -j ACCEPT(dns block)/usr/bin/dotnet dotnet restore --no-cache(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.