Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pack with --no-build #413

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Fix pack with --no-build #413

merged 1 commit into from
Aug 8, 2023

Conversation

kzu
Copy link
Member

@kzu kzu commented Aug 4, 2023

Fixes #407

@kzu kzu added the bug Something isn't working label Aug 4, 2023
@kzu kzu enabled auto-merge (rebase) August 4, 2023 22:31
@kzu kzu disabled auto-merge August 4, 2023 22:35
@kzu
Copy link
Member Author

kzu commented Aug 4, 2023 •
edited
Loading

Waiting for feedback from #407 (comment) by @voroninp

@kzu
Copy link
Member Author

kzu commented Aug 8, 2023

Merging, we can tweak if needed when we get further feedback.

@kzu kzu merged commit c0fceec into main Aug 8, 2023
3 checks passed
@kzu kzu deleted the dev/no-build branch August 8, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error NETSDK1085: The 'NoBuild' property was set to true but the 'Build' target was invoked.
1 participant
@kzu