Merge pull request #14 from devinweb/feature/fix-#13

throw error message if the transaction doesn't exist

Author: darbaoui

phpunit.xml.dist

@@ -10,11 +10,8 @@
          stopOnFailure="false"
 >
     <testsuites>
-        <testsuite name="Unit">
-            <directory suffix="Test.php">./tests/Unit</directory>
-        </testsuite>
-        <testsuite name="Feature">
-            <directory suffix="Test.php">./tests/Feature</directory>
+        <testsuite name="Package Test">
+            <directory suffix=".php">./tests/</directory>
         </testsuite>
     </testsuites>
     <php>

resources/lang/ar.json

@@ -1,3 +1,4 @@
 {
-    "failed_message": "حدث خطأ في عملية الدفع يرجى المحاولة مرة أخرى."
+    "failed_message": "حدث خطأ في عملية الدفع يرجى المحاولة مرة أخرى.",
+    "invalid_checkout_id": "checkout_id غير صالح"
 }

src/Support/TransactionBuilder.php

@@ -3,6 +3,7 @@
 namespace Devinweb\LaravelHyperpay\Support;
 
 use Illuminate\Support\Arr;
+use Illuminate\Validation\ValidationException;
 
 class TransactionBuilder
 {
@@ -60,6 +61,10 @@ public function findByIdOrCheckoutId($id)
         $transaction_model = config('hyperpay.transaction_model');
         $transaction = app($transaction_model)->whereId($id)->orWhere('checkout_id', $id)->first();
 
+        if (! $transaction) {
+            throw ValidationException::withMessages([__('invalid_checkout_id')]);
+        }
+
         return $transaction;
     }