New Feature: webpage now displays <img> of SVG #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks awesome :) |
Panquesito7
reviewed
Sep 5, 2021
There was a problem hiding this comment.
Overall, everything else looks great! Awesome work, @Thomas-Boi! 😄👍
Co-authored-by: David Leal <halfpacho@gmail.com>
Thank you 😄. It's all inspired by your idea.
I think that's a bit of an overkill. I'll leave a note telling people that they can change the width and height to get what they want though. |
…icons/devicon into thomas/feature/imgTagCreator
Panquesito7
approved these changes
Sep 7, 2021
There was a problem hiding this comment.
LGTM 🚀 Thank you for contributing, @Thomas-Boi and @renevds! 😄👍
This was referenced Sep 7, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature section
Double check these details before you open a PR
This PR adds/fixes
Adds a section to display the
<img>of the selected SVG to the website.This offers users an option to link external SVGs rather than using inline/pure SVGs. This will change dynamically depending on the currently selected SVGs.
I've tested the feature and here's what it looks like:
The feature above was inspired by this site which was submitted by @renevds on Discord.
Also redo the icon section and add a hint on how to increase the icon's size:
Notes
Later on, I'll work on a copy button to make things easier for the user. That'll be in a separate PR.