Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: jetbrains (plain, original) #711

Merged
merged 6 commits into from
Jul 4, 2021

Conversation

tupaschoal
Copy link
Contributor

Original
jetbrains-original
Plain
jetbrains-plain

I removed the eps, as it's not applicable anymore. I also removed the aliases, as the new icon doesn't look like a line.

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if removing the .eps file is a good idea. @Thomas-Boi, thoughts?

icons/jetbrains/jetbrains-plain.svg Outdated Show resolved Hide resolved
icons/jetbrains/jetbrains-original.svg Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
devicon.json Show resolved Hide resolved
icons/jetbrains/jetbrains-plain.svg Outdated Show resolved Hide resolved
@Panquesito7 Panquesito7 linked an issue Jul 2, 2021 that may be closed by this pull request
@Thomas-Boi
Copy link
Member

Hey @Panquesito7,

Since he's updating Jetbrains, he's removing the old .eps file. I think this is fine since it doesn't make sense to have an old .eps file while the icons are different

@Thomas-Boi Thomas-Boi changed the title Part of #128: Update JetBrains icons new icon: jetbrains (original, plain) Jul 4, 2021
@Thomas-Boi Thomas-Boi changed the title new icon: jetbrains (original, plain) Part of #128: Update JetBrains icons Jul 4, 2021
@Thomas-Boi Thomas-Boi changed the title Part of #128: Update JetBrains icons new icon: jetbrains (plain, original) Jul 4, 2021
@Thomas-Boi Thomas-Boi added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Jul 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

@Thomas-Boi
Copy link
Member

Another great icon @tupaschoal ! Thank you for your work 😄

@Thomas-Boi Thomas-Boi dismissed Panquesito7’s stale review July 4, 2021 22:44

Outdated and has been applied

@Thomas-Boi Thomas-Boi merged commit eb1cdbc into devicons:develop Jul 4, 2021
@tupaschoal tupaschoal deleted the update-jetbrains branch July 5, 2021 00:38
@tupaschoal
Copy link
Contributor Author

I'm enjoying doing it :D

@amacado amacado mentioned this pull request Aug 14, 2021
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger enhancement feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JetBrains icons out of date
4 participants