Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] get-build-release-message not getting the PRs that are past the Release date but are merged after. #841

Closed
Thomas-Boi opened this issue Sep 7, 2021 · 1 comment
Labels
bug Use this label for pointing out bugs in-develop The fix/feature is present in `develop` branch but not merged into `master` yet

Comments

@Thomas-Boi
Copy link
Member

Bug description

As seen in this PR, the build-bot only found 4 PRs:
image

There are actually 6 icons that should be included. These are not found by the bot because I coded it like this:

  • Query the API for the PRs
  • Get all the PRs UP UNTIL the PR with a name matching "Release v"

The two missing PRs (bottom two here which were added manually by me), when searched on GitHub, shows up AFTER the "Release v" PR. I think GitHub sorted them by open dates, not merged date.

Possible fixes or solutions

Find a way to query the APIs based on merge dates rather than opened dates. If not, probably goes past the end PR a little bit.

Additional information

Not critical but we should have it.

@Thomas-Boi Thomas-Boi added the bug Use this label for pointing out bugs label Sep 7, 2021
@Thomas-Boi
Copy link
Member Author

GitHub now has an auto generated release message: https://github.blog/2021-10-04-beta-github-releases-improving-release-experience/

We could use this

@Thomas-Boi Thomas-Boi added the in-develop The fix/feature is present in `develop` branch but not merged into `master` yet label Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Use this label for pointing out bugs in-develop The fix/feature is present in `develop` branch but not merged into `master` yet
Projects
None yet
Development

No branches or pull requests

1 participant