Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JetBrains icons out of date #128

Closed
MattIPv4 opened this issue Jun 16, 2018 · 11 comments · Fixed by #711
Closed

JetBrains icons out of date #128

MattIPv4 opened this issue Jun 16, 2018 · 11 comments · Fixed by #711
Assignees
Labels
request:icon When requesting a new icon to be added to the collection or a refactor use this label in your issue

Comments

@MattIPv4
Copy link

MattIPv4 commented Jun 16, 2018

All the JetBrains product icons appear to be the versions prior to the modern branding update the occurred. Could these all be updated to the modern branding set that JetBrains uses?

See https://www.jetbrains.com/company/press/index.html#product-logos for all current product icons.

@iamclaytonray
Copy link
Contributor

@MattIPv4 - Thanks for opening an issue on my fork. I didn't think Konpa would make me a collaborator so I didn't ask but I ended up one anyways! We're going to stick with this repo so we don't have to overhaul to another repo, migrating issues, PRs, and so on. Please bear with me as I try to get everything situated (reviewing PRs, issues, and so on) before we really start rolling things out and getting releases out! Thank you so much for your contributions!

@MattIPv4
Copy link
Author

@iamclaytonray any update regarding all of this?

@amacado amacado added request:icon When requesting a new icon to be added to the collection or a refactor use this label in your issue and removed feature: new Icon labels Jun 8, 2020
tupaschoal added a commit to tupaschoal/devicon that referenced this issue Jul 2, 2021
@tupaschoal
Copy link
Contributor

tupaschoal commented Jul 2, 2021

For the sake of documenting, here are the JetBrains app icons currently on devicons which would require update:

  • IntelliJ
  • PhpStorm
  • PyCharm
  • RubyMine
  • WebStorm

Ah, and here is where to get the assets:
https://www.jetbrains.com/company/brand/#logos-and-icons-product-logos

@Panquesito7 Panquesito7 linked a pull request Jul 2, 2021 that will close this issue
Thomas-Boi pushed a commit that referenced this issue Jul 4, 2021
* Part of #128: Update JetBrains icons

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

* Tag jetbrains with ide

Co-authored-by: David Leal <halfpacho@gmail.com>
@aminoxix
Copy link
Member

@Panquesito7: It seems like, we have to close this issue, get resolved in #711. WDYT?

@MattIPv4
Copy link
Author

The updated JetBrains icon has a missing s in the logo, and that's the only one that has been updated, not all the other product icons.

@aminoxix
Copy link
Member

The updated JetBrains icon has a missing s in the logo, and that's the only one that has been updated, not all the other product icons.

Thanks for your response, Will sure fix that! 🙂

@aminoxix
Copy link
Member

aminoxix commented Nov 1, 2021

Original having s in it:
jetbrains-original

seems like JetBrains-plain missed it:-
jetbrains-plain

Solution:-
Shall I contribute this in .svg?
jetbrains-plain

@aminoxix
Copy link
Member

aminoxix commented Nov 2, 2021

@Panquesito7: Do you mind assigning me this issue?

@Snailedlt
Copy link
Collaborator

Would be nice if you could also use "jetbrains" as a tag for all jetbrains products. If I understand the use of aliases correctly, it would make it much easier to search for on the https://devicon.dev/ website ;)

@Panquesito7
Copy link
Member

Would be nice if you could also use "jetbrains" as a tag for all jetbrains products. If I understand the use of aliases correctly, it would make it much easier to search for on the https://devicon.dev/ website ;)

The aliases field is to make an alias for the icon's versions. For example:

      "aliases": [
          {
              "base": "original",
              "alias": "plain"
          },
          {
              "base": "original-wordmark",
              "alias": "plain-wordmark"
          }
      ]

@Snailedlt
Copy link
Collaborator

This issue should not have been closed imo, since only the jetbrains logo got updated, and not all of the other icons specified in the issue.

But there is now a new issue that's basically a duplicate of this one ( #1125 ), along with a PR in the works #1182 , so this being closed now is fine.

Would be great to have some input on the PR other than just mine though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request:icon When requesting a new icon to be added to the collection or a refactor use this label in your issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants