fix invalid pin detection, improve tests

Author: Nikolay-Kha

firmware-src/sources/dhcommand_parser.c

@@ -201,6 +201,8 @@ char * ICACHE_FLASH_ATTR parse_params_pins_set(const char *params, unsigned int
 				char * res = readUIntField(&jparser, AF_PIN, &out->pin, fields, readedfields, 0);
 				if(res)
 					return res;
+				if(out->pin >= DH_GPIO_PIN_COUNT)
+					return "Wrong pin";
 				continue;
 			} else if(strcmp_value(&jparser, "ref") == 0) {
 				char * res = readFloatField(&jparser, AF_REF, &out->ref, fields, readedfields);

firmware-tests/requests.html

@@ -156,15 +156,18 @@
   addtest("onewire/master/read", {"count":1}, false, {"value":"Command for reading is not specified"});
   addtest("onewire/master/read", {"count":1,"data":"AA==","pin":2}, false, {"value":"No response"});
   addtest("onewire/master/write", {"data":"AA=="}, false, {"value":"No response"});
-  addtest("onewire/master/write", {"data":"AA==","pin":244}, false, {"value":"Wrong onewire pin"});
+  addtest("onewire/master/write", {"data":"AA==","pin":244}, false, {"value":"Wrong pin"});
+  addtest("onewire/master/write", {"data":"AA==","pin":34}, false, {"value":"Wrong pin"});
+  addtest("onewire/master/write", {"data":"AA==","pin":10}, false, {"value":"Wrong onewire pin"});
   addtest("onewire/master/write", {"data":"#$==","pin":2}, false, {"value":"Data is broken"});
   addtest("onewire/master/write", {"data":"AA==","pin":2}, false, {"value":"No response"});
   addtest("onewire/master/int", {"pin":"2"}, false, {"value":"Unexpected parameter"});
   addtest("onewire/master/int", {"2":"presence"}, true, {"value":""});
   addtest("onewire/master/int", {"2":"disable"}, true, {"value":""});
   addtest("onewire/master/search", null, true, {"found":[],"pin":"2"});
   addtest("onewire/master/alarm", {"pin":"2"}, true, {"found":[],"pin":"2"});
-  addtest("onewire/dht/read", {"pin":"22"}, false, {"value":"Wrong onewire pin"});
+  addtest("onewire/dht/read", {"pin":"22"}, false, {"value":"Wrong pin"});
+  addtest("onewire/dht/read", {"pin":10}, false, {"value":"Wrong onewire pin"});
   addtest("onewire/dht/read", null, false, {"value":"No response"});