Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Gutenberg blocks are not included in search #70

Open
villesiltala opened this issue Jun 2, 2020 · 0 comments
Open

Dynamic Gutenberg blocks are not included in search #70

villesiltala opened this issue Jun 2, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@villesiltala
Copy link

Currently, RediPress strips all tags before storing the post_content field with RediSearch. This also strips all HTML comment tags which leads to dynamic block content not being queryable for searches. This is problematic, especially for ACF blocks. They store data as JSON in the HTML comment. Still, not all dynamic block content is wanted for searches. For instance, blocks rendering link lists for posts might not add relevant data.

A solution for this could be to first parse blocks from the content field. Then run them through a filter defining all blocks to be allowed in search. After filtering the final list, blocks could be run through rendering to get the actual content. This would enable developers to define exactly which blocks are needed for searches and which not.

@villesiltala villesiltala added the enhancement New feature or request label Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant