Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏷️ Add TypeScript typings #237

Merged
merged 3 commits into from
Oct 31, 2020

Conversation

ishan-chhabra
Copy link
Contributor

Description

This adds TypeScript definitions file to react-otp-input.
​

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update
    ​

Changes

  • Add definitions file
    ​

Flags

  • N/A
    ​

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in

@ishan-chhabra ishan-chhabra added the enhancement New feature or request label Oct 17, 2020
@linear
Copy link

linear bot commented Oct 17, 2020

@apollonian apollonian changed the base branch from master to next October 31, 2020 07:17
@apollonian apollonian merged commit a0ab6e6 into next Oct 31, 2020
@apollonian apollonian deleted the fro-95-migrate-react-otp-input-to-typescript branch October 31, 2020 11:05
@apollonian
Copy link
Contributor

@all-contributors please add @ishan-chhabra for code

@allcontributors
Copy link
Contributor

@apollonian

I've put up a pull request to add @ishan-chhabra! πŸŽ‰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants