Sanitize geomcolname #769
Merged
Sanitize geomcolname #769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh those CI failures are unrelated because we don't pin a single version of ruff. I'll bump the ruff version in a separate PR |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I am changing
Fix sanity check of
geom_col_nameto actually check the whole string.How I did it
re.match(re_match)was matching any string containing any[a-zA-Z]character, regardless of the rest.The solution is
re.fullmatch(). Another way would have been to appendr"^...$"to the beginning and end ofre_match.How you can test it
Wrote test
test_sanitize_column_name().Related Issues
Closes #768
In general, the issue of hardcoded-sql-expression is still out there.