Skip to content

Commit 64a9fa5

Browse files
authored
perf: Call np.mean once across axis instead of once per column (#995)
1 parent 74ace7c commit 64a9fa5

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

lonboard/_geoarrow/ops/centroid.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,16 +67,18 @@ def update_coords(self, coords: Array) -> None:
6767

6868
if self.x is None or self.y is None:
6969
assert self.x is None and self.y is None and self.num_items == 0
70-
self.x = float(np.mean(np_arr[:, 0]))
71-
self.y = float(np.mean(np_arr[:, 1]))
70+
mean = np.mean(np_arr, axis=0)
71+
self.x = float(mean[0])
72+
self.y = float(mean[1])
7273
self.num_items = new_chunk_len
7374
return
7475

7576
existing_modifier = self.num_items / (self.num_items + new_chunk_len)
7677
new_chunk_modifier = new_chunk_len / (self.num_items + new_chunk_len)
7778

78-
new_chunk_avg_x = np.mean(np_arr[:, 0])
79-
new_chunk_avg_y = np.mean(np_arr[:, 1])
79+
new_chunk_avg = np.mean(np_arr, axis=0)
80+
new_chunk_avg_x = new_chunk_avg[0]
81+
new_chunk_avg_y = new_chunk_avg[1]
8082

8183
existing_x_avg = self.x
8284
existing_y_avg = self.y

0 commit comments

Comments
 (0)