Create a base model and generic serialization. #144
Merged
+179
−141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
approved these changes
Jul 21, 2023
|
|
||
| ref: https://gist.github.com/sgillies/2217756#__geo_interface | ||
| """ | ||
| return self.model_dump(mode="json") |
There was a problem hiding this comment.
Yeah, this was a nice little fix here when I realized the old exclude_unset=True was potentially problematic. Not so much on the Geometry types, but on Feature / FeatureCollection it could affect Properties if someone has defaults set in that model.
it might be safer to put something more specific, we can just go with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vincentsarago This is what I ended up doing based on #143
I realized all of the classes included BBox and the GeoInterfaceMixin, so combined it all in one new base.
I added a class variable
__exclude_if_none__that is used to determine which fields are excluded. Not particularly invested in the name, was just what I came up with. Also considered starting it with__geojson_pydanticto be a bit closer to some of the__pydanticones.Its getting late and my brain has quit on me. I think there were more tests I wanted to add but I will have to take another look in the morning.