Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat (stac): enable transaction extensions #163

Merged
merged 3 commits into from
Nov 27, 2023
Merged

feat (stac): enable transaction extensions #163

merged 3 commits into from
Nov 27, 2023

Conversation

vincentsarago
Copy link
Member

This PR adds the possibility to enable the Transactions extensions within the custom runtime

cc @emileten @oliverroick

emileten
emileten reviewed Nov 24, 2023
View reviewed changes
docker-compose.custom.yml Outdated Show resolved Hide resolved
emileten
emileten suggested changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@emileten emileten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the tiny bug I pointed out, could just remove the single quotes from the commented out example. Also, why not turning on the transaction extension by default ?

@vincentsarago vincentsarago merged commit 80a7255 into main Nov 27, 2023
2 checks passed
@vincentsarago vincentsarago deleted the feat/enable-transactionn-extensions branch November 27, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emileten emileten Awaiting requested review from emileten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincentsarago @emileten