Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade rpt2 to latest v0.32.0 to fix monorepos #967

Merged

Conversation

agilgur5
Copy link
Contributor

@agilgur5 agilgur5 commented Jun 2, 2022

Intro

Hi 👋 , by way of introduction, I help maintain rollup-plugin-typescript2 and also formerly solo-maintained TSDX for ~1.5 years (the creator hasn't been involved in years and his abusiveness was central to me leaving OSS for over a year), so I'm very familiar with the internals of microbundle as well.

I was investigating ezolenko/rollup-plugin-typescript2#295 and found that microbundle is on an older version of rpt2, causing several issues in this repo.

Summary

Upgrade rpt2 to v0.32.0 to fix various monorepo issues

Details

References

Testing

It doesn't look like microbundle's fixtures support monorepos yet (would require setting up symlinks or pnpm etc), so as a result I didn't add a whole test suite for that which would've made this PR significantly more complex and involved in the internals of the testing set-up.
Once I set-up an integration test for this in rpt2, I could contribute a similar fixture downstream here, but it may require a different CI workflow to not break the existing test set-up

- rpt2 v0.30.0 supports compiling files outside of the project directory
  with no additional configuration (e.g. of `rootDir`) as it upgraded
  its dep of `@rollup/pluginutils` to v4, which has a breaking change
  affecting `createFilter`
  - essentially, the change to `@rollup/pluginutils` allows transforming
    files outside of the project dir

- rpt2 v0.32.0 supports symlinks, such as with monorepos built w/ pnpm

- previously, microbundle was using rpt2 v0.29.0, which is about ~1.5
  years out-of-date
@changeset-bot
Copy link

changeset-bot bot commented Jun 2, 2022

🦋 Changeset detected

Latest commit: 336a485

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
microbundle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rschristian rschristian merged commit 4ad4b76 into developit:master Jun 2, 2022
@preact-bot preact-bot mentioned this pull request Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants