chore: Adding flag & docs for jsxFragment #930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8f6509f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rschristian
force-pushed
the
chore/jsx-fragment-flag
branch
from
2847857 to
8f6509f
Compare
ForsakenHarmony
approved these changes
Mar 3, 2022
Collaborator
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 3, 2022
#809 (comment) I removed the `options.jsx === 'React.createElement'` thing as it's no longer relevant with `jsxFragmentFactory` (see #623 (comment)) and we set default values in the CLI for both `jsx` and `jsxFragment`, so we don't really need extra fallback values.
Merged
Contributor
|
Timed out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#809 (comment)
I removed the
options.jsx === 'React.createElement'thing as it's no longer relevant withjsxFragmentFactory(see #623 (comment)) and we set default values in the CLI for bothjsxandjsxFragment, so we don't really need extra fallback values.