remove type and fix some stuff

Author: preplant

src/main/java/net/oceanias/opal/setting/OSetting.java

@@ -36,14 +36,4 @@ protected OSetting(final String pretty, final T initial) {
     public void reset() {
         this.value = initial;
     }
-
-    public abstract Type type();
-
-    public enum Type {
-        BOOLEAN,
-        CHOICE,
-        DOUBLE,
-        INTEGER,
-        STRING,
-    }
 }

src/main/java/net/oceanias/opal/setting/impl/OBooleanSetting.java

@@ -23,13 +23,8 @@ public OBooleanSetting(final String pretty, final boolean initial) {
         super(pretty, initial);
     }
 
-    @Override
-    public Type type() {
-        return Type.BOOLEAN;
-    }
-
     @RequiredArgsConstructor
-    public static final class Item extends AbstractItem {
+    public static class Item extends AbstractItem {
         private final OBooleanSetting setting;
 
         @Override

src/main/java/net/oceanias/opal/setting/impl/OChoiceSetting.java

@@ -44,13 +44,8 @@ public void value(final T value) {
         this.value = value;
     }
 
-    @Override
-    public Type type() {
-        return Type.CHOICE;
-    }
-
     @RequiredArgsConstructor
-    public static final class Item<T> extends AbstractItem {
+    public static class Item<T> extends AbstractItem {
         private final OChoiceSetting<T> setting;
 
         @Override
@@ -71,7 +66,7 @@ public ItemProvider getItemProvider(final Player viewer) {
 
             lore.add("&fCurrent: &6" + setting.value);
             lore.add("");
-            lore.add("&fChoices:");
+            lore.add("&eChoices:");
 
             for (final T choice : setting.choices) {
                 final String colour = choice.equals(setting.value) ? "&a" : "&7";

src/main/java/net/oceanias/opal/setting/impl/ODoubleSetting.java

@@ -47,12 +47,7 @@ public void value(Double value) {
         this.value = value;
     }
 
-    @Override
-    public Type type() {
-        return Type.DOUBLE;
-    }
-
-    public class Item extends AbstractItem {
+    public static class Item extends AbstractItem {
         private final ODoubleSetting setting;
         private final double change;
 

src/main/java/net/oceanias/opal/setting/impl/OIntegerSetting.java

@@ -47,12 +47,7 @@ public void value(Integer value) {
         this.value = value;
     }
 
-    @Override
-    public Type type() {
-        return Type.INTEGER;
-    }
-
-    public class Item extends AbstractItem {
+    public static class Item extends AbstractItem {
         private final OIntegerSetting setting;
         private final int change;
 

src/main/java/net/oceanias/opal/setting/impl/OStringSetting.java

@@ -62,13 +62,8 @@ public void value(String value) {
         this.value = value;
     }
 
-    @Override
-    public Type type() {
-        return Type.STRING;
-    }
-
     @RequiredArgsConstructor
-    public static final class Item extends AbstractItem {
+    public static class Item extends AbstractItem {
         private final OStringSetting setting;
 
         @Override