Fix volume rounding error

devappd · devappd · commit 4687c8c74171 · 2021-01-28T02:07:39.000-05:00
diff --git a/music_html5.c b/music_html5.c
@@ -450,13 +450,13 @@ static void *MusicHTML5_CreateFromFile(const char *file)
 static void MusicHTML5_SetVolume(void *context, int volume)
 {
     MusicHTML5 *music = (MusicHTML5 *)context;
-    volume /= MIX_MAX_VOLUME;
+    float normalized_volume = ((float)volume) / MIX_MAX_VOLUME;
 
     EM_ASM({
         const id = $0;
         const volume = Math.min(Math.max(0, $1), 1);
         Module["SDL2Mixer"].music[id].volume = volume;
-    }, music->id, volume);
+    }, music->id, normalized_volume);
 }
 
 static void MusicHTML5_Stop(void *context);

Original file line number	Diff line number	Diff line change
`@@ -450,13 +450,13 @@ static void MusicHTML5_CreateFromFile(const char file)`
`450`	`450`	`static void MusicHTML5_SetVolume(void *context, int volume)`
`451`	`451`	`{`
`452`	`452`	`MusicHTML5 music = (MusicHTML5 )context;`
`453`		`- volume /= MIX_MAX_VOLUME;`
	`453`	`+ float normalized_volume = ((float)volume) / MIX_MAX_VOLUME;`
`454`	`454`
`455`	`455`	`EM_ASM({`
`456`	`456`	`const id = $0;`
`457`	`457`	`const volume = Math.min(Math.max(0, $1), 1);`
`458`	`458`	`Module["SDL2Mixer"].music[id].volume = volume;`
`459`		`- }, music->id, volume);`
	`459`	`+ }, music->id, normalized_volume);`
`460`	`460`	`}`
`461`	`461`
`462`	`462`	`static void MusicHTML5_Stop(void *context);`