Skip to content

Commit 5a23b85

Browse files
committed
👌 Review improvements (isoos#6)
1 parent ba68358 commit 5a23b85

File tree

4 files changed

+4
-8
lines changed

4 files changed

+4
-8
lines changed

lib/src/auth/auth.dart

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
1-
/// Source: https://github.com/mongo-dart/mongo_dart/blob/c761839efbf47ec556f853dec85debb4cb9370f7/lib/src/auth/auth.dart
2-
31
import 'package:crypto/crypto.dart';
4-
import 'package:postgres/src/auth/sasl_authenticator.dart';
52
import 'package:sasl_scram/sasl_scram.dart';
63

74
import '../../postgres.dart';
85
import '../server_messages.dart';
96
import 'md5_authenticator.dart';
7+
import 'sasl_authenticator.dart';
108

119
enum AuthenticationScheme { MD5, SCRAM_SHA_256 }
1210

lib/src/auth/md5_authenticator.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import 'auth.dart';
1010

1111
class MD5Authenticator extends PostgresAuthenticator {
1212
static final String name = 'MD5';
13-
late List<int> _salt;
1413

1514
final UsernamePasswordCredential credentials;
1615

@@ -19,9 +18,9 @@ class MD5Authenticator extends PostgresAuthenticator {
1918
@override
2019
void onMessage(AuthenticationMessage message) {
2120
final reader = ByteDataReader()..add(message.bytes);
22-
_salt = reader.read(4, copy: true);
21+
final salt = reader.read(4, copy: true);
2322

24-
final authMessage = AuthMD5Message(connection.username!, connection.password!, _salt);
23+
final authMessage = AuthMD5Message(connection.username!, connection.password!, salt);
2524

2625
connection.socket!.add(authMessage.asBytes());
2726
}

lib/src/auth/sasl_authenticator.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/// Source: https://github.com/mongo-dart/mongo_dart/blob/c761839efbf47ec556f853dec85debb4cb9370f7/lib/src/auth/sasl_authenticator.dart
21
import 'dart:typed_data';
32

43
import 'package:buffer/buffer.dart';

lib/src/connection_fsm.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ class _PostgreSQLConnectionStateSocketConnected
6969
_PostgreSQLConnectionState onMessage(ServerMessage message) {
7070

7171
completer.completeError(PostgreSQLException(
72-
'Unsupported message ${message.toString()}, closing connection.'));
72+
'Unsupported message "${message.toString()}", closing connection.'));
7373

7474
return _PostgreSQLConnectionStateClosed();
7575
}

0 commit comments

Comments
 (0)