[Refactor] Renamed suggestion text property and moved the logic to get suggestion text to own function

Author: ThiagoNP

AutoComplete/AutoComplete.js

@@ -16,6 +16,13 @@ class AutoComplete extends Component {
     )
   }
 
+  getSuggestionText = (suggestion) => {
+    if (this.props.suggestionObjectTextProperty) {
+      return suggestion[this.props.suggestionObjectTextProperty]
+    }
+
+    return suggestion
+  }
 
   isSimilar = (value, suggestionText) => {
     const minimumScore = this.props.minimumSimilarityScore
@@ -35,12 +42,7 @@ class AutoComplete extends Component {
     }
 
     return newSuggestions.reduce((suggestions, suggestion) => {
-      let suggestionText
-      if (this.props.textProperty) {
-        suggestionText = suggestion[this.props.textProperty]
-      } else {
-        suggestionText = suggestion
-      }
+      const suggestionText = this.getSuggestionText(suggestion)
 
       if (!suggestionText || !this.isSimilar(value, suggestionText)) {
         return suggestions
@@ -118,9 +120,9 @@ AutoComplete.propTypes = {
   value: React.PropTypes.string,
   minimumSimilarityScore: React.PropTypes.number,
   comparationFuzziness: React.PropTypes.number,
-  textProperty: React.PropTypes.string,
+  suggestionObjectTextProperty: React.PropTypes.string,
   onChangeText: React.PropTypes.func,
-  onSelect: React.PropTypes.func,
+  onSelect: React.PropTypes.func.isRequired,
   suggestionsWrapperStyle: React.PropTypes.any,
   suggestionStyle: React.PropTypes.any,
   suggestionTextStyle: React.PropTypes.any,

AutoComplete/AutoComplete.spec.js

@@ -27,7 +27,7 @@ describe('AutoComplete', () => {
     const params = {
       value: '0.5',
       suggestions: fakeSuggestions,
-      textProperty: 'text'
+      suggestionObjectTextProperty: 'text'
     }
 
     const wrapper = shallow(
@@ -47,7 +47,7 @@ describe('AutoComplete', () => {
     let params = {
       value: '0.5',
       suggestions: fakeSuggestions,
-      textProperty: 'text'
+      suggestionObjectTextProperty: 'text'
     }
 
     const wrapper = shallow(
@@ -70,7 +70,7 @@ describe('AutoComplete', () => {
     const params = {
       value: '0.5',
       suggestions: fakeSuggestions,
-      textProperty: 'text',
+      suggestionObjectTextProperty: 'text',
       onSelect: jest.fn()
     }
 

AutoComplete/__snapshots__/AutoComplete.spec.js.snap

@@ -55,6 +55,7 @@ ShallowWrapper {
         "_reactInternalInstance": [Circular],
         "context": Object {},
         "filterSugestions": [Function],
+        "getSuggestionText": [Function],
         "isSimilar": [Function],
         "onChangeText": [Function],
         "props": Object {