[Fix] Fixed parameter order in string score method and increased default minimum similarity score

Author: ThiagoNP

AutoComplete/AutoComplete.js

@@ -26,7 +26,7 @@ class AutoComplete extends Component {
 
   isSimilar = (value, suggestionText) => {
     const suggestionScore = stringScore(
-      value, suggestionText, this.props.comparationFuzziness
+      suggestionText, value, this.props.comparationFuzziness
     )
 
     return suggestionScore >= this.props.minimumSimilarityScore
@@ -132,7 +132,7 @@ AutoComplete.propTypes = {
 }
 
 AutoComplete.defaultProps = {
-  minimumSimilarityScore: 0.45,
+  minimumSimilarityScore: 0.6,
   comparationFuzziness: 0.5
 }
 

AutoComplete/AutoComplete.spec.js

@@ -27,7 +27,8 @@ describe('AutoComplete', () => {
     const params = {
       value: '0.5',
       suggestions: fakeSuggestions,
-      suggestionObjectTextProperty: 'text'
+      suggestionObjectTextProperty: 'text',
+      minimumSimilarityScore: 0.5
     }
 
     const wrapper = shallow(
@@ -47,7 +48,8 @@ describe('AutoComplete', () => {
     let params = {
       value: '0.5',
       suggestions: fakeSuggestions,
-      suggestionObjectTextProperty: 'text'
+      suggestionObjectTextProperty: 'text',
+      minimumSimilarityScore: 0.5
     }
 
     const wrapper = shallow(
@@ -71,7 +73,8 @@ describe('AutoComplete', () => {
       value: '0.5',
       suggestions: fakeSuggestions,
       suggestionObjectTextProperty: 'text',
-      onSelect: jest.fn()
+      onSelect: jest.fn(),
+      minimumSimilarityScore: 0.5
     }
 
     const wrapper = shallow(

AutoComplete/__snapshots__/AutoComplete.spec.js.snap

@@ -14,7 +14,7 @@ ShallowWrapper {
     }>
     <TextInput
         comparationFuzziness={0.5}
-        minimumSimilarityScore={0.45}
+        minimumSimilarityScore={0.6}
         onChangeText={[Function]}
         style={
             Object {
@@ -31,7 +31,7 @@ ShallowWrapper {
       }>
       <TextInput
             comparationFuzziness={0.5}
-            minimumSimilarityScore={0.45}
+            minimumSimilarityScore={0.6}
             onChangeText={[Function]}
             style={
                   Object {
@@ -48,7 +48,7 @@ ShallowWrapper {
       "_context": Object {},
       "_currentElement": <AutoComplete
         comparationFuzziness={0.5}
-        minimumSimilarityScore={0.45} />,
+        minimumSimilarityScore={0.6} />,
       "_hostContainerInfo": null,
       "_hostParent": null,
       "_instance": AutoComplete {
@@ -60,7 +60,7 @@ ShallowWrapper {
         "onChangeText": [Function],
         "props": Object {
           "comparationFuzziness": 0.5,
-          "minimumSimilarityScore": 0.45,
+          "minimumSimilarityScore": 0.6,
         },
         "refs": Object {},
         "renderSuggestions": [Function],
@@ -93,7 +93,7 @@ ShallowWrapper {
           }>
           <TextInput
                     comparationFuzziness={0.5}
-                    minimumSimilarityScore={0.45}
+                    minimumSimilarityScore={0.6}
                     onChangeText={[Function]}
                     style={
                               Object {
@@ -109,7 +109,7 @@ ShallowWrapper {
           }>
           <TextInput
                     comparationFuzziness={0.5}
-                    minimumSimilarityScore={0.45}
+                    minimumSimilarityScore={0.6}
                     onChangeText={[Function]}
                     style={
                               Object {
@@ -129,6 +129,6 @@ ShallowWrapper {
   "root": [Circular],
   "unrendered": <AutoComplete
     comparationFuzziness={0.5}
-    minimumSimilarityScore={0.45} />,
+    minimumSimilarityScore={0.6} />,
 }
 `;

__mocks__/string_score.js

@@ -1,5 +1,5 @@
 const stringScore = (leftString, rightString) => {
-  if (parseFloat(leftString) <= parseFloat(rightString)) {
+  if (parseFloat(leftString) >= parseFloat(rightString)) {
     return parseFloat(rightString)
   }