Don't autodisable overrides for js projects (#723)

alcuadrado · web-flow · commit ed6f85b82ad6 · 2022-06-16T15:34:47.000+02:00
* Don't autodisable overrides for js projects

* Update docs
diff --git a/.changeset/bright-roses-bathe.md b/.changeset/bright-roses-bathe.md
@@ -0,0 +1,5 @@
+---
+'@typechain/hardhat': patch
+---
+
+Don't autodisable overrides for js projects
diff --git a/packages/hardhat/README.md b/packages/hardhat/README.md
@@ -104,7 +104,7 @@ module.exports = {
     target: 'ethers-v5',
     alwaysGenerateOverloads: false, // should overloads with full signatures like deposit(uint256) be generated always, even if there are no overloads?
     externalArtifacts: ['externalArtifacts/*.json'], // optional array of glob patterns with external artifacts to process (for example external libs from node_modules)
-    dontOverrideCompile: false // defaults to true for javascript projects
+    dontOverrideCompile: false // defaults to false
   },
 }
 ```
diff --git a/packages/hardhat/src/config.ts b/packages/hardhat/src/config.ts
@@ -9,7 +9,7 @@ export function getDefaultTypechainConfig(config: HardhatConfig): TypechainConfi
     alwaysGenerateOverloads: false,
     discriminateTypes: false,
     tsNocheck: false,
-    dontOverrideCompile: config.paths.configFile.endsWith('.js'),
+    dontOverrideCompile: false,
   }
 
   return {

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'@typechain/hardhat': patch
 +---
++
 +Don't autodisable overrides for js projects
Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ module.exports = {`
`104`	`104`	`target: 'ethers-v5',`
`105`	`105`	`alwaysGenerateOverloads: false, // should overloads with full signatures like deposit(uint256) be generated always, even if there are no overloads?`
`106`	`106`	`externalArtifacts: ['externalArtifacts/*.json'], // optional array of glob patterns with external artifacts to process (for example external libs from node_modules)`
`107`		`- dontOverrideCompile: false // defaults to true for javascript projects`
	`107`	`+ dontOverrideCompile: false // defaults to false`
`108`	`108`	`},`
`109`	`109`	`}`
`110`	`110`	```
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ export function getDefaultTypechainConfig(config: HardhatConfig): TypechainConfi`
`9`	`9`	`alwaysGenerateOverloads: false,`
`10`	`10`	`discriminateTypes: false,`
`11`	`11`	`tsNocheck: false,`
`12`		`- dontOverrideCompile: config.paths.configFile.endsWith('.js'),`
	`12`	`+ dontOverrideCompile: false,`
`13`	`13`	`}`
`14`	`14`
`15`	`15`	`return {`