remove cookies parameter on do_post and do_get (#23)

* remove cookies paramter on do_post and do_get

* adjust tests

Author: guyp-descope

descope/auth.py

@@ -59,15 +59,13 @@ def __init__(self, project_id: str, public_key: str = None, base_uri: str = None
     def do_get(
         self,
         uri: str,
-        cookies=None,
         params=None,
         allow_redirects=None,
         pswd: str = None,
     ) -> requests.Response:
         response = requests.get(
             f"{self.base_url}{uri}",
             headers=self._get_default_headers(pswd),
-            cookies=cookies,
             params=params,
             allow_redirects=allow_redirects,
         )
@@ -77,14 +75,11 @@ def do_get(
             )
         return response
 
-    def do_post(
-        self, uri: str, body: dict, cookies=None, pswd: str = None
-    ) -> requests.Response:
+    def do_post(self, uri: str, body: dict, pswd: str = None) -> requests.Response:
         response = requests.post(
             f"{self.base_url}{uri}",
             headers=self._get_default_headers(pswd),
             data=json.dumps(body),
-            cookies=cookies,
         )
         if not response.ok:
             raise AuthException(
@@ -305,7 +300,7 @@ def _get_default_headers(self, pswd: str = None):
 
     def _refresh_token(self, refresh_token: str) -> dict:
         uri = Auth._compose_refresh_token_url()
-        response = self.do_get(uri, None, None, None, refresh_token)
+        response = self.do_get(uri, None, None, refresh_token)
 
         resp = response.json()
         auth_info = self._generate_auth_info(

descope/authmethod/exchanger.py

@@ -20,7 +20,7 @@ def exchange_token(self, code: str) -> dict:
 
         uri = EndpointsV1.exchangeTokenPath
         params = Exchanger._compose_exchange_params(code)
-        response = self._auth.do_get(uri, None, params, False)
+        response = self._auth.do_get(uri, params, False)
         resp = response.json()
         jwt_response = self._auth._generate_jwt_response(
             resp, response.cookies.get(REFRESH_SESSION_COOKIE_NAME, None)

descope/authmethod/magiclink.py

@@ -151,7 +151,7 @@ def _update_user_email(
             identifier, email, cross_device
         )
         uri = EndpointsV1.updateUserEmailOTPPath
-        return self._auth.do_post(uri, body, None, refresh_token)
+        return self._auth.do_post(uri, body, refresh_token)
 
     def _update_user_phone(
         self,
@@ -172,7 +172,7 @@ def _update_user_phone(
             identifier, phone, cross_device
         )
         uri = EndpointsV1.updateUserPhoneOTPPath
-        return self._auth.do_post(uri, body, None, refresh_token)
+        return self._auth.do_post(uri, body, refresh_token)
 
     @staticmethod
     def _compose_signin_url(method: DeliveryMethod) -> str:

descope/authmethod/oauth.py

@@ -19,7 +19,7 @@ def start(self, provider: str, return_url: str = "") -> dict:
 
         uri = EndpointsV1.oauthStart
         params = OAuth._compose_start_params(provider, return_url)
-        response = self._auth.do_get(uri, None, params, False)
+        response = self._auth.do_get(uri, params, False)
 
         return response.json()
 

descope/authmethod/otp.py

@@ -154,7 +154,7 @@ def update_user_email(
 
         uri = EndpointsV1.updateUserEmailOTPPath
         body = OTP._compose_update_user_email_body(identifier, email)
-        self._auth.do_post(uri, body, None, refresh_token)
+        self._auth.do_post(uri, body, refresh_token)
 
     def update_user_phone(
         self, method: DeliveryMethod, identifier: str, phone: str, refresh_token: str
@@ -185,7 +185,7 @@ def update_user_phone(
 
         uri = OTP._compose_update_phone_url(method)
         body = OTP._compose_update_user_phone_body(identifier, phone)
-        self._auth.do_post(uri, body, None, refresh_token)
+        self._auth.do_post(uri, body, refresh_token)
 
     @staticmethod
     def _compose_signup_url(method: DeliveryMethod) -> str:

descope/authmethod/saml.py

@@ -24,7 +24,7 @@ def start(self, tenant: str, return_url: str = None) -> dict:
 
         uri = EndpointsV1.authSAMLStart
         params = SAML._compose_start_params(tenant, return_url)
-        response = self._auth.do_get(uri, None, params)
+        response = self._auth.do_get(uri, params)
 
         return response.json()
 

descope/authmethod/totp.py

@@ -72,7 +72,7 @@ def update_user(self, identifier: str, refresh_token: str) -> None:
 
         uri = EndpointsV1.updateTOTPPath
         body = TOTP._compose_update_user_body(identifier)
-        response = self._auth.do_post(uri, body, None, refresh_token)
+        response = self._auth.do_post(uri, body, refresh_token)
 
         return response.json()
         # Response should have these schema:

descope/authmethod/webauthn.py

@@ -113,7 +113,7 @@ def add_device_start(self, identifier: str, refresh_token: str, origin: str):
 
         uri = EndpointsV1.deviceAddAuthWebauthnStart
         body = WebauthN._compose_add_device_start_body(identifier, origin)
-        response = self._auth.do_post(uri, body, None, refresh_token)
+        response = self._auth.do_post(uri, body, refresh_token)
 
         return response.json()
 

descope/descope_client.py

@@ -94,4 +94,4 @@ def logout(self, refresh_token: str) -> requests.Response:
             )
 
         uri = EndpointsV1.logoutPath
-        return self._auth.do_get(uri, None, None, None, refresh_token)
+        return self._auth.do_get(uri, None, None, refresh_token)

samples/webauthn_web_sample_app.py

@@ -87,6 +87,7 @@ def webauthn_add_device_start():
 def webauthn_add_device_finish():
     data = request.get_json()
     descope_client.webauthn.add_device_finish(data["transactionId"], data["response"])
+    return jsonify("{}")
 
 
 if __name__ == "__main__":