Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write Helper contract to cover loss tests #9

Open
Zergity opened this issue Apr 23, 2023 · 0 comments
Open

write Helper contract to cover loss tests #9

Zergity opened this issue Apr 23, 2023 · 0 comments
Assignees

Comments

@Zergity
Copy link
Contributor

Zergity commented Apr 23, 2023

from main to simple, some tests have to be removed as the UTR is changed to be as simple as possible; any complex flow should be done in application's Helper or Adapter contracts

UTR changes:

  • token will never, and should never be held in the UTR contract, even temporarily in the transaction. For any logic where tokens need to be held temporarily, application's Helper contracts are the recommended places to be used instead.
  • removed: ALLOWANCE mode, anything *_FROM_ROUTER mode, action.flags, amountInSource
  • amountInMax renamed to amountIn
@Zergity Zergity assigned anhnq82 and BerlinP and unassigned anhnq82 Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants