fixed MysqlAdapter check in Utf8mb4Fix migration #442
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #441.
In MySQL databases, the text columns
dataandfailure_messageshould have a length limit ofMEDIUM, but they do not. This is because the if condition in Utf8mb4Fix will never be satisfied, since theMysqlAdapterwill be wrapped inside theCakeAdapter.This PR fixes the if condition, getting the adapter inside the wrapper before checking it's instance.