Skip to content

Conversation

@GustavoPeixoto
Copy link

This PR is related to #441.

In MySQL databases, the text columns data and failure_message should have a length limit of MEDIUM, but they do not. This is because the if condition in Utf8mb4Fix will never be satisfied, since the MysqlAdapter will be wrapped inside the CakeAdapter.

This PR fixes the if condition, getting the adapter inside the wrapper before checking it's instance.

@dereuromark
Copy link
Owner

Does removing and rerunning this migrations work for u? Or any issues?

@dereuromark
Copy link
Owner

Given that this is quite old of a migration it does seem ir could be a good idea to have new migration.

@GustavoPeixoto
Copy link
Author

Does removing and rerunning this migrations work for u? Or any issues?

Doesn't work because job_type was renamed to job_task by MigrationQueueRename.

The first part of the migration doesn't need to rerun, only the part inside the if.

So i think, its a better idea to write a new migration, only with the part that matters.

@GustavoPeixoto
Copy link
Author

Fixed it by creating DataColumnLength.

I tested it, and it works. It doesn't undo any changes made by previous migrations.

@dereuromark dereuromark merged commit 12a81bb into dereuromark:cake4 Sep 11, 2025
8 checks passed
@GustavoPeixoto
Copy link
Author

Will 6.9.3 be released?

@dereuromark
Copy link
Owner

https://github.com/dereuromark/cakephp-queue/releases/tag/6.9.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants