From d0e83522e10b1923146c4db6ef241fe2640338ef Mon Sep 17 00:00:00 2001 From: Derek Burgman Date: Wed, 13 Jul 2022 12:08:18 -0500 Subject: [PATCH] fix: fixed AbstractSingleItemDbxFirebaseDocument setFirestoreCollection - fixed issue where AbstractSingleItemDbxFirebaseDocument's setFirestoreCollection did not handle the Maybe input properly --- .../model/store/store.subcollection.document.ts | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/packages/dbx-firebase/src/lib/model/store/store.subcollection.document.ts b/packages/dbx-firebase/src/lib/model/store/store.subcollection.document.ts index f979886e2..7002dde1d 100644 --- a/packages/dbx-firebase/src/lib/model/store/store.subcollection.document.ts +++ b/packages/dbx-firebase/src/lib/model/store/store.subcollection.document.ts @@ -79,12 +79,16 @@ export class AbstractSingleItemDbxFirebaseDocument>) => { - const id = (firestoreCollection as SingleItemFirestoreCollection).singleItemIdentifier; - - if (id != null) { - return { ...state, firestoreCollection, id }; + if (firestoreCollection != null) { + const id = (firestoreCollection as SingleItemFirestoreCollection).singleItemIdentifier; + + if (id != null) { + return { ...state, firestoreCollection, id }; + } else { + throw new Error('AbstractSingleItemDbxFirebaseDocument only accepts SingleItemFirestoreCollection values with a singleItemIdentifier set for setFirestoreCollection.'); + } } else { - throw new Error('AbstractSingleItemDbxFirebaseDocument only accepts SingleItemFirestoreCollection values with a singleItemIdentifier set for setFirestoreCollection.'); + return { ...state, firestoreCollection: null }; } });