Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow customization of log indicator toggles #2041

Merged

Conversation

mikesmithgh
Copy link
Contributor

@mikesmithgh mikesmithgh commented Apr 4, 2023

Demo of change:

k9slogindicator.mov

I noticed timestamps do not have the ability to customize as well. I see there is issue for customizing pod colors (#935) . I was thinking to add a note about timestamp do that issue as well.

Copy link
Collaborator

@slimus slimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikesmithgh thank you! I have 1 question here.

internal/view/log_indicator.go Show resolved Hide resolved
Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikesmithgh Cool. Thank you for this PR Mike!

@derailed derailed merged commit 465c947 into derailed:master May 7, 2023
@derailed derailed mentioned this pull request May 7, 2023
placintaalexandru pushed a commit to placintaalexandru/k9s that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants