You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
K9s may panic when viewing logs during a rollout restart.
panic: send on closed channel
goroutine 13753 [running]:
github.com/derailed/k9s/internal/dao.readLogs(0x1d9a2a0, 0xc001719860, 0xc003a7f980, 0xc0009aac40, 0x32, 0xc0016b2480, 0x16, 0x1388, 0x1010100, 0x0, ...)
/Users/fernand/go_wk/derailed/src/github.com/derailed/k9s/internal/dao/pod.go:270 +0x401
created by github.com/derailed/k9s/internal/dao.tailLogs
/Users/fernand/go_wk/derailed/src/github.com/derailed/k9s/internal/dao/pod.go:247 +0x454
Additionally, any k9s crash makes the terminal it ran on completely useless, it'd be nice to recover near the root level, restore the terminal to a not useless state and then continue crashing.
To Reproduce
Steps to reproduce the behavior:
Go to deployments
Initiate a rolling restart (ctrl+t)
Attach to the logs (l)
May get panic
Expected behavior
An in-app error message if we're doing something bad.
Describe the bug
K9s may panic when viewing logs during a rollout restart.
Additionally, any k9s crash makes the terminal it ran on completely useless, it'd be nice to recover near the root level, restore the terminal to a not useless state and then continue crashing.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
An in-app error message if we're doing something bad.
Screenshots
https://imgur.com/VPYjHQh
Versions (please complete the following information):
The text was updated successfully, but these errors were encountered: