Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when viewing deployment logs during rollout #635

Closed
baliame opened this issue Mar 26, 2020 · 0 comments
Closed

Crash when viewing deployment logs during rollout #635

baliame opened this issue Mar 26, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@baliame
Copy link

baliame commented Mar 26, 2020




Describe the bug
K9s may panic when viewing logs during a rollout restart.

panic: send on closed channel
goroutine 13753 [running]:
github.com/derailed/k9s/internal/dao.readLogs(0x1d9a2a0, 0xc001719860, 0xc003a7f980, 0xc0009aac40, 0x32, 0xc0016b2480, 0x16, 0x1388, 0x1010100, 0x0, ...)
/Users/fernand/go_wk/derailed/src/github.com/derailed/k9s/internal/dao/pod.go:270 +0x401
created by github.com/derailed/k9s/internal/dao.tailLogs
/Users/fernand/go_wk/derailed/src/github.com/derailed/k9s/internal/dao/pod.go:247 +0x454

Additionally, any k9s crash makes the terminal it ran on completely useless, it'd be nice to recover near the root level, restore the terminal to a not useless state and then continue crashing.

To Reproduce
Steps to reproduce the behavior:

  1. Go to deployments
  2. Initiate a rolling restart (ctrl+t)
  3. Attach to the logs (l)
  4. May get panic

Expected behavior
An in-app error message if we're doing something bad.

Screenshots
https://imgur.com/VPYjHQh

Versions (please complete the following information):

  • OS: Ubuntu 19.10
  • K9s 0.18.1
  • K8s 1.14.10-gke.24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants