Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typed wrong password, still logged in #216

Closed
CPColin opened this issue Feb 17, 2016 · 5 comments
Closed

Typed wrong password, still logged in #216

CPColin opened this issue Feb 17, 2016 · 5 comments

Comments

@CPColin
Copy link

CPColin commented Feb 17, 2016

I don't have my password saved, so Pidgin asks me for my Facebook password when I start it. I accidentally typed the wrong one in and was still logged in. I can even type stuff like "nope" and it works. I'm not sure if my real password is getting cached somewhere, or what.

@ghokun
Copy link

ghokun commented Feb 18, 2016

Account information (including passwords) can be found at ~/.purple/accounts.xml

@dequis
Copy link
Owner

dequis commented Feb 18, 2016

Duplicate of #193

The password is only used for the first login, it uses access tokens afterwards.

@CPColin
Copy link
Author

CPColin commented Feb 18, 2016

In my opinion, there's two bugs, then:

  1. The dialog box shows on every login, even though it's not needed after the first time.
  2. A user could save his or her password in accounts.xml, even though that password isn't used.

Seems like the dialog should be suppressed, if possible, and the "Save Password" option should be disabled, again, if possible.

@dequis
Copy link
Owner

dequis commented Feb 18, 2016

I think that's all out of our control, they are pidgin UI issues.

The password is used and saving it is useful - access tokens don't last forever and the password is needed to refresh them. But we have no way to tell the UI that we need the password only sometimes.

@EionRobb
Copy link
Collaborator

@dequis what about with the password-optional flag on the connection?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants