feat(tap): some best practice rules map to RGAA (#4895)

Mark the following best practice rules as part of RGAA:

- focus-order-semantics (experimental)
- region
- skip-link
- table-duplicate-name

Author: WilcoFiers

build/tasks/validate.js

@@ -405,7 +405,7 @@ function findTagIssues(tags) {
       standardTag: standardTags[0] ?? null,
       criterionTags
     };
-    if (bestPracticeTags.length !== 0) {
+    if (name !== 'RGAA' && bestPracticeTags.length !== 0) {
       issues.push(`${name} tags cannot be used along side best-practice tag`);
     }
     if (standardTags.length === 0) {
@@ -417,7 +417,7 @@ function findTagIssues(tags) {
       issues.push(`Expected at least one ${name} criterion tag, got 0`);
     }
 
-    if (wcagLevelRegex) {
+    if (wcagLevelRegex && standards.WCAG) {
       const wcagLevel = standards.WCAG.standardTag;
       if (!wcagLevel.match(wcagLevelRegex)) {
         issues.push(`${name} rules not allowed on ${wcagLevel}`);

lib/rules/focus-order-semantics.json

@@ -3,7 +3,13 @@
   "impact": "minor",
   "selector": "div, h1, h2, h3, h4, h5, h6, [role=heading], p, span",
   "matches": "inserted-into-focus-order-matches",
-  "tags": ["cat.keyboard", "best-practice", "experimental"],
+  "tags": [
+    "cat.keyboard",
+    "best-practice",
+    "RGAAv4",
+    "RGAA-12.8.1",
+    "experimental"
+  ],
   "metadata": {
     "description": "Ensure elements in the focus order have a role appropriate for interactive content",
     "help": "Elements in the focus order should have an appropriate role"

lib/rules/region.json

@@ -2,7 +2,7 @@
   "id": "region",
   "impact": "moderate",
   "selector": "body *",
-  "tags": ["cat.keyboard", "best-practice"],
+  "tags": ["cat.keyboard", "best-practice", "RGAAv4", "RGAA-9.2.1"],
   "metadata": {
     "description": "Ensure all page content is contained by landmarks",
     "help": "All page content should be contained by landmarks"

lib/rules/skip-link.json

@@ -3,7 +3,7 @@
   "impact": "moderate",
   "selector": "a[href^=\"#\"], a[href^=\"/#\"]",
   "matches": "skip-link-matches",
-  "tags": ["cat.keyboard", "best-practice"],
+  "tags": ["cat.keyboard", "best-practice", "RGAAv4", "RGAA-12.7.1"],
   "metadata": {
     "description": "Ensure all skip links have a focusable target",
     "help": "The skip-link target should exist and be focusable"

lib/rules/table-duplicate-name.json

@@ -2,7 +2,7 @@
   "id": "table-duplicate-name",
   "impact": "minor",
   "selector": "table",
-  "tags": ["cat.tables", "best-practice"],
+  "tags": ["cat.tables", "best-practice", "RGAAv4", "RGAA-5.2.1"],
   "metadata": {
     "description": "Ensure the <caption> element does not contain the same text as the summary attribute",
     "help": "Tables should not have the same summary and caption"