fix(cli): respect --exit regardless of other flags (#750)

AdnoC · web-flow · commit bfa232800d55 · 2023-06-16T11:18:03.000-04:00
diff --git a/packages/cli/src/bin/cli.test.ts b/packages/cli/src/bin/cli.test.ts
@@ -9,6 +9,12 @@ import { version } from '../../package.json';
 import runCLI from '../testutils/';
 
 const SIMPLE_HTML_FILE = path.join(__dirname, '..', 'testutils', 'simple.html');
+const SIMPLE_CLEAN_HTML_FILE = path.join(
+  __dirname,
+  '..',
+  'testutils',
+  'simple-clean.html'
+);
 const SIMPLE_HTML_SOURCE = fs.readFileSync(SIMPLE_HTML_FILE, 'utf8');
 const PATH_TO_AXE_250 = path.resolve(
   __dirname,
@@ -147,6 +153,18 @@ describe('cli', () => {
         );
       }
     });
+
+    it('should exit zero if violations are found', async () => {
+      try {
+        await runCLI(`file://${SIMPLE_CLEAN_HTML_FILE}`, '--exit');
+      } catch (error) {
+        assert.equal(error.exitCode, 0);
+        assert.include(
+          error.stdout,
+          'Violation of "marquee" with 1 occurrences!'
+        );
+      }
+    });
   });
 
   describe('--dir', () => {
diff --git a/packages/cli/src/bin/index.ts b/packages/cli/src/bin/index.ts
@@ -133,6 +133,24 @@ const cli = async (
       }
     }
 
+    if (exit) {
+      let exitErr = false;
+      /* istanbul ignore if */
+      if (Array.isArray(outcome)) {
+        for (const res of outcome) {
+          if (res.violations.length > 0) {
+            exitErr = true;
+            break;
+          }
+        }
+      } else {
+        exitErr = outcome.violations.length > 0;
+      }
+      if (exitErr) {
+        process.exit(1);
+      }
+    }
+
     /* istanbul ignore if */
     if (silentMode) {
       return;
diff --git a/packages/cli/src/lib/events.ts b/packages/cli/src/lib/events.ts
@@ -69,10 +69,6 @@ export default ({
         };
         cliReporter(`\n${JSON.stringify(metadata, null, 2)}`);
       }
-
-      if (exit) {
-        process.exit(1);
-      }
     }
   };
 };
diff --git a/packages/cli/src/testutils/simple-clean.html b/packages/cli/src/testutils/simple-clean.html
@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<html lang="en">
+  <head>
+    <meta charset="UTF-8" />
+    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
+    <title>Document</title>
+  </head>
+  <body>
+    <h1>This is a document.</h1>
+  </body>
+</html>

Original file line number	Diff line number	Diff line change
`@@ -69,10 +69,6 @@ export default ({`
`69`	`69`	`};`
`70`	`70`	cliReporter(`\n${JSON.stringify(metadata, null, 2)}`);
`71`	`71`	`}`
`72`		`-`
`73`		`- if (exit) {`
`74`		`- process.exit(1);`
`75`		`- }`
`76`	`72`	`}`
`77`	`73`	`};`
`78`	`74`	`};`