Skip to content

Commit dc4a75c

Browse files
committed
Don't use {{remote_user}} in writable
1 parent baeb41e commit dc4a75c

File tree

1 file changed

+11
-6
lines changed

1 file changed

+11
-6
lines changed

recipe/deploy/writable.php

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,11 @@
6363
$recursive = get('writable_recursive') ? '-R' : '';
6464
$sudo = get('writable_use_sudo') ? 'sudo' : '';
6565

66+
$remoteUser = get('remote_user', false);
67+
if (empty($remoteUser)) {
68+
$remoteUser = run('whoami');
69+
}
70+
6671
if (empty($dirs)) {
6772
return;
6873
}
@@ -88,7 +93,7 @@
8893
run("$sudo chgrp -H $recursive {{http_group}} $dirs");
8994
run("$sudo chmod g+rwx $dirs");
9095
} catch (RunException $exception) {
91-
warning("Make sure `{{remote_user}}` is in `{{http_group}}` group: `usermod -a -G {{http_group}} {{remote_user}}`");
96+
warning("Make sure `$remoteUser` is in `{{http_group}}` group: `usermod -a -G {{http_group}} $remoteUser`");
9297
throw $exception;
9398
}
9499
} elseif ($mode === 'chmod') {
@@ -99,7 +104,7 @@
99104
// Try OS-X specific setting of access-rights
100105

101106
run("$sudo chmod +a \"$httpUser allow delete,write,append,file_inherit,directory_inherit\" $dirs");
102-
run("$sudo chmod +a \"{{remote_user}} allow delete,write,append,file_inherit,directory_inherit\" $dirs");
107+
run("$sudo chmod +a \"$remoteUser allow delete,write,append,file_inherit,directory_inherit\" $dirs");
103108
} elseif (commandExist('setfacl')) {
104109
if (empty($sudo)) {
105110
// When running without sudo, exception may be thrown
@@ -112,13 +117,13 @@
112117
$hasfacl = run("getfacl -p $dir | grep \"^user:$httpUser:.*w\" | wc -l");
113118
// Set ACL for directory if it has not been set before
114119
if (!$hasfacl) {
115-
run("setfacl -L $recursive -m u:\"$httpUser\":rwX -m u:{{remote_user}}:rwX $dir");
116-
run("setfacl -dL $recursive -m u:\"$httpUser\":rwX -m u:{{remote_user}}:rwX $dir");
120+
run("setfacl -L $recursive -m u:\"$httpUser\":rwX -m u:$remoteUser:rwX $dir");
121+
run("setfacl -dL $recursive -m u:\"$httpUser\":rwX -m u:$remoteUser:rwX $dir");
117122
}
118123
}
119124
} else {
120-
run("$sudo setfacl -L $recursive -m u:\"$httpUser\":rwX -m u:{{remote_user}}:rwX $dirs");
121-
run("$sudo setfacl -dL $recursive -m u:\"$httpUser\":rwX -m u:{{remote_user}}:rwX $dirs");
125+
run("$sudo setfacl -L $recursive -m u:\"$httpUser\":rwX -m u:$remoteUser:rwX $dirs");
126+
run("$sudo setfacl -dL $recursive -m u:\"$httpUser\":rwX -m u:$remoteUser:rwX $dirs");
122127
}
123128
} else {
124129
$alias = currentHost()->getAlias();

0 commit comments

Comments
 (0)