Make default_selector a fallback rather than an override (#3950) (#4009)

florinr08 · web-flow · commit 101da0f4d8ad · 2025-01-29T13:34:45.000+01:00
diff --git a/src/Command/SelectCommand.php b/src/Command/SelectCommand.php
@@ -51,7 +51,8 @@ protected function selectHosts(Input $input, Output $output): array
         if (!$output->isDecorated() && !defined('NO_ANSI')) {
             define('NO_ANSI', 'true');
         }
-        $selector = Deployer::get()->config->get('default_selector', $input->getArgument('selector'));
+        $selector = $input->getArgument('selector');
+        $selector = empty($selector) ? Deployer::get()->config->get('default_selector') : $selector;
         $selectExpression = is_array($selector) ? implode(',', $selector) : $selector;
 
         if (empty($selectExpression)) {

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,8 @@ protected function selectHosts(Input $input, Output $output): array`
`51`	`51`	`if (!$output->isDecorated() && !defined('NO_ANSI')) {`
`52`	`52`	`define('NO_ANSI', 'true');`
`53`	`53`	`}`
`54`		`- $selector = Deployer::get()->config->get('default_selector', $input->getArgument('selector'));`
	`54`	`+ $selector = $input->getArgument('selector');`
	`55`	`+ $selector = empty($selector) ? Deployer::get()->config->get('default_selector') : $selector;`
`55`	`56`	`$selectExpression = is_array($selector) ? implode(',', $selector) : $selector;`
`56`	`57`
`57`	`58`	`if (empty($selectExpression)) {`