Skip to content

feat: complete volume purchasing location support #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

neilmartin83
Copy link
Contributor

@neilmartin83 neilmartin83 commented May 7, 2025

Change

Thank you for your contribution !

Flesh out support for managing volume purchasing locations, so CRUD is now working for them via the SDK. I also have an incoming PR for a new Terraform provider resource that works with these changes.

Please note this depends on the following PR being accepted first, so that updates (PATCH requests) work: deploymenttheory/go-api-http-client-integrations#12

Type of Change

Please DELETE options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)
  • Refactor (refactoring code, removing code, changing code structure)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@neilmartin83 neilmartin83 requested a review from ShocOne as a code owner May 7, 2025 18:32
@ShocOne ShocOne merged commit 408ed30 into deploymenttheory:main May 8, 2025
2 of 4 checks passed
@neilmartin83 neilmartin83 deleted the nm-volume-purchasing-locations-2025-05-07 branch May 8, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants