Upgrade Bundler to 2.5.11 and RubyGems to 3.5.11 #9862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
deivid-rodriguez/bump-rubygems-and-bundler
branch
from
4b1901c
to
ebef257
Compare
deivid-rodriguez
force-pushed
the
deivid-rodriguez/bump-rubygems-and-bundler
branch
from
ebef257
to
eee52c1
Compare
deivid-rodriguez
changed the title
deivid-rodriguez
force-pushed
the
deivid-rodriguez/bump-rubygems-and-bundler
branch
4 times, most recently
from
cf5210f
to
9030a5e
Compare
|
This should be ready now! Some expectations changed, but I think it's just because Dependabot will be smarter now and able to create more PRs. So I mostly updated the expectations. |
|
Thanks @deivid-rodriguez! Can we also get rid of our recent bundler patch with this upgrade? |
|
Oh good point, let me remove it! |
deivid-rodriguez
force-pushed
the
deivid-rodriguez/bump-rubygems-and-bundler
branch
from
804e265
to
5121ef7
Compare
|
I think I may have pushed too many times and reached some rate limit, apologies! This should be ready now I believe. |
5 tasks
abdulapopoola
approved these changes
Jun 4, 2024
|
Thanks @deivid-rodriguez ! |
|
Let me know if you find any problems! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It needs the tweak I mentioned in rubygems/rubygems#7659 (comment).
Two of the failing specs I think are just because Bundler got smarter (and Dependabot should get smarter too as a side effect), so I updated expectations.
There's one more failing that I'm not sure about and I'd need to dig in more.
Opening a WIP PR to check smoke tests too.